Require type equality for operation handler input/output types #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace covariant/contravariant type checking with strict identity checks. Operation handler implementations must now declare the exact same input and output types as the service definition, rather than allowing subtype relationships. This simplifies type validation and makes the type contract more explicit. Also replace dataclass_transform with standard @DataClass decorator in tests.
Remove the now-unused is_subtype function since type checking requires exact type identity. Also fix import ordering in test files to follow PEP 8 conventions. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Add missing colon and space in type mismatch error messages - Fix typo: OutputCovarianceImplOutputCannnotBeStrictSuperclass -> OutputCovarianceImplOutputCannotBeStrictSuperclass Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Adds test cases using parameterized types (list[int], dict[str, bool]) to validate that equality comparison (!=) works correctly for type checking. This ensures generic types are properly compared since they create new objects on each evaluation, making identity comparison (is) unreliable. Also adds missing InputContravarianceImplInputCannotBeSubclass to the parametrize list. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Fix stale docstring that described covariance/contravariance - Add tests clarifying that Any requires exact match, not wildcard Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
VegetarianOrc
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
is) for operation handler input/output types instead of allowing subtype relationshipsis_subtypefunction which is no longer needed@dataclass_transform()with actual@dataclass()decorator in test filesTest plan
🤖 Generated with Claude Code