Support for Pico offset limits #448#1066
Open
preamp-org wants to merge 5 commits intongscopeclient:masterfrom
Open
Support for Pico offset limits #448#1066preamp-org wants to merge 5 commits intongscopeclient:masterfrom
preamp-org wants to merge 5 commits intongscopeclient:masterfrom
Conversation
Collaborator
|
I don't like this approach because it adds around trips and will perform badly on high latency connections and doesn't cache - we call GetChannelOffset multiple times every video frame. The clamping code needs to be clientside within the driver and just understand what the limits are and limit the max offset as soon as you call SetChannelOffset() without adding round trips. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added function "GetChannelOffset" so that the current offset limit is reported back correctly from the pico-bridge.
Please also update the pico-bridge accordingly.