Conversation
|
@jattasNI can you give a first pass when you have time? thanks! |
packages/spright-components/src/table-column/breakpoint/specs/table-column-breakpoint-hld.md
Outdated
Show resolved
Hide resolved
packages/spright-components/src/table-column/breakpoint/specs/table-column-breakpoint-hld.md
Outdated
Show resolved
Hide resolved
packages/spright-components/src/table-column/breakpoint/specs/table-column-breakpoint-hld.md
Outdated
Show resolved
Hide resolved
packages/spright-components/src/table-column/breakpoint/specs/table-column-breakpoint-hld.md
Show resolved
Hide resolved
packages/spright-components/src/table-column/breakpoint/specs/table-column-breakpoint-hld.md
Outdated
Show resolved
Hide resolved
packages/spright-components/src/table-column/breakpoint/specs/table-column-breakpoint-hld.md
Outdated
Show resolved
Hide resolved
packages/spright-components/src/table-column/breakpoint/specs/table-column-breakpoint-hld.md
Show resolved
Hide resolved
packages/spright-components/src/table-column/breakpoint/specs/table-column-breakpoint-hld.md
Outdated
Show resolved
Hide resolved
packages/spright-components/src/table-column/breakpoint/specs/table-column-breakpoint-hld.md
Outdated
Show resolved
Hide resolved
…table-column-breakpoint-hld.md Co-authored-by: Jesse Attas <jattasNI@users.noreply.github.com>
…/nimble into users/vgleason/breakpoint-hld
|
|
||
| ### Internationalization | ||
|
|
||
| Tooltips will use label provider strings for the default text ("Add breakpoint" / "Remove breakpoint"). |
There was a problem hiding this comment.
@jattasNI -- correct me if I'm wrong, but we don't have a label provider for ok components, do we? I don't think this string belongs in the nimble label providers either.
There was a problem hiding this comment.
Correct, all of our existing label providers are in Nimble. I was envisioning that we could add a new one to OK without too much trouble but haven't verified that to be true. If there are major barriers, we could add a new one to Nimble that contains all the OK labels. That would be conceptually similar to how other tokens like icons and colors are defined in nimble-tokens even if they're only used by Spright/OK.
Assuming the new label provider goes in OK we'd have to decide on its name / organization structure. I think I'd advocate for having one per group of OK components like we do for Nimble, so naming this one something like LabelProviderTableBreakpoint.
There was a problem hiding this comment.
don't have a label provider for ok components
we could add a new one to OK
Just to double check, are we expecting this in spright components or ok components (to set expectation on design review, nimble ownership, etc). Looks like the files are currently targeting spright but the examples in the doc are for ok
I think I'd advocate for having one per group of OK components like we do for Nimble, so naming this one something like LabelProviderTableBreakpoint.
Would that be ok-label-provider-table (collection of all OK table related component strings) or ok-label-provider-table-column-breakpoint (labels just for the breakpoint column)? Don't think I feel strongly either way but the later may be more aligned with the spirit of ok components as components that are each owned individually by the contributor so minimizes coupling to other ok components which may have different contributors.
There was a problem hiding this comment.
Just to double check, are we expecting this in spright components or ok components (
For some reason my title change didn't save, but targeting Ok. The spec is still in spright for now because I wanted to be able to diff it, but I will move to Ok once I'm done making changes to the doc.
|
|
||
| ### Framework Integration | ||
|
|
||
| - Standard Blazor wrapper |
There was a problem hiding this comment.
It might be good to enumerate the pieces that need to be handled in the blazor wrapper since it's more than just the component.
For example, that list might be:
- Adding the
BreakpointStateenum (and making sure the values serialize correctly within the table data) - Adding the event on the column
- Adding the new column component
- Label provider work (?) -- This is related to my other comment. I'm not sure there is a label provider to put the new strings.
Pull Request
🤨 Rationale
Clients need a way to provide a breakpoint in the nimble table. This is the implementation of the breakpoint IxD
👩💻 Implementation
N/A
🧪 Testing
N/A
✅ Checklist