Conversation
|
|
||
| <!-- *Highlight any open questions for discussion during the spec PR. Before the spec is approved these should typically be resolved with the answers being incorporated in the spec document.* --> | ||
|
|
||
| Visual design does not currently represent full matrix of states: `severity` x `selected` x `interaction` (hover, mouse down, tab focus). |
There was a problem hiding this comment.
@fredvisser know if we expect to have those visual design updates for selected versions of the severity states / any risk there is pushback on having those states that might impact the implementation (i.e. resistance to all the severity states being selectable)?
There was a problem hiding this comment.
We have some additional states clarified, but some still missing. Shared the following states grid with @fredvisser to try and fill out with brandon to make sure all cases covered:
| - Events | ||
| - CSS custom properties --> | ||
| - CSS native properties | ||
| - Will respond to width / height sizing (on the axis corresponding to orientation) and show overflow scroll buttons following the pattern of breadcrumb |
There was a problem hiding this comment.
fyi, @fredvisser this concept of overflow scrollers like breadcrumb / tabs is not captured in the visual design. curious if brandon would have any concerns. In particular the vertical orientation having the scroll buttons would be new to this component
There was a problem hiding this comment.
Chatted with @fredvisser and if cheap for both horizontal and vertical scroll buttons then do both. Otherwise the horizontal case and something else for vertical, i.e. make a requirement apps size correctly and overflow hide or scroll (if doesn't add complexity to sizing).
|
|
||
| The `nimble-step` and `nimble-anchor-step` are elements representing individual steps with `nimble-step` behaving as a card button (i.e. a button with a concept of a `selected` visual appearance that does not change behavior) and a `nimble-anchor-step` looking visually identical but with link behaviors. | ||
|
|
||
| The `step` elements will primarily render a provided nimble icon (and new nimble icons for the visuals of digits 0 - 9 will be added). When a non-default severity is provided the provided icon will be replaced with an icon representing the severity. |
There was a problem hiding this comment.
fyi @fredvisser we would need these digit icons as requests to brandon
There was a problem hiding this comment.
@fredvisser will send icon requests to Brandon
| - CSS native properties | ||
| - Will respond to width / height sizing (on the axis corresponding to orientation) and show overflow scroll buttons following the pattern of breadcrumb | ||
| - Slots | ||
| - default: supports `nimble-step` and `nimble-anchor-step` children |
There was a problem hiding this comment.
Actually we'll leave default unused and make a step slot. Has the benefit of making it easier to ignore unexpected child elements.
3 participants
Pull Request
🤨 Rationale
<hr>sectioning (can lean into headers / TOCs if want more sections) and added an "Interactions" section as an analog to the "Visual Appearance" section✅ Checklist