Open
Conversation
atoms are not garbage collected, it's a bit dangerous to convert all hash keys to atoms unless you have a finite set of keys in couchbase. If the data is at all user generated, this essentially results in a memory leak otherwise.
Newer libraries use the flags: json: 0x02 << 24 raw: 0x03 << 24 utf8: 0x04 << 24 So updating the transcoder to support these flags for interoperability. Also I prefered not to use the single line function declarations for readability (personal preference)
was not correctly detecting flags. needed to use a mask.
When editing cb docs in the management console the flag is changed to 0x01 which really doesn't mean anything. We're just going to treat this flag as JSON.
n1rvana
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.