Skip to content

[v24.x] lib: backport _tls_common and _tls_wrap refactors #61044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
targos wants to merge 3 commits into
base: v24.x-staging
Choose a base branch
from
Open

[v24.x] lib: backport _tls_common and _tls_wrap refactors #61044

targos wants to merge 3 commits into from

Conversation

@targos
Copy link
Member

@targos targos commented Dec 13, 2025

This is the same as the original change, minus the process.emitWarning calls and unit tests that expect the deprecation warnings.

Refs: #57643

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 13, 2025

Review requested:

  • @nodejs/crypto
  • @nodejs/net
  • @nodejs/startup

@targos targos mentioned this pull request Dec 13, 2025
Merged
@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v24.x Issues that can be reproduced on v24.x or PRs targeting the v24.x-staging branch. labels Dec 13, 2025
@targos
Copy link
Member Author

targos commented Dec 23, 2025

/cc @dario-piotrowicz

@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 1, 2026
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 1, 2026
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 1, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/70646/

dario-piotrowicz and others added 3 commits January 23, 2026 15:29
@dario-piotrowicz @targos
lib: backport _tls_common and _tls_wrap refactors
ace9a0c 
This is the same as the original change, minus the `process.emitWarning`
calls and unit tests that expect the deprecation warnings, plus
re-application of the fixes for CVE-2025-59465 and CVE-2026-21637.

Refs: nodejs#57643
@RafaelGSS @targos
lib: add TLSSocket default error handler
a013120 
Cherry-pick f0a8916
@mcollina @targos
tls: route callback exceptions through error handlers
2ea4e1a 
Cherry-pick c357a39
@targos
Copy link
Member Author

targos commented Jan 23, 2026

To be transparent: I rebased, ignored the conflict in lib/_tls_wrap.js (keep full deletion of the code) and reapplied the security fixes by cherry-picking them from the v25.x branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@avivkeller avivkeller avivkeller approved these changes

Assignees

No one assigned

Labels

lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v24.x Issues that can be reproduced on v24.x or PRs targeting the v24.x-staging branch.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@targos @nodejs-github-bot @avivkeller @dario-piotrowicz @RafaelGSS @mcollina