Skip to content

[v24.x backport] repl: move completion logic to internal module #61046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
targos wants to merge 1 commit into
base: v24.x-staging
Choose a base branch
from
Open

[v24.x backport] repl: move completion logic to internal module #61046

targos wants to merge 1 commit into from
+878 −784

Conversation

@targos
Copy link
Member

@targos targos commented Dec 13, 2025

Backport of #59889

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. repl Issues and PRs related to the REPL subsystem. v24.x Issues that can be reproduced on v24.x or PRs targeting the v24.x-staging branch. labels Dec 13, 2025
dario-piotrowicz
dario-piotrowicz approved these changes Dec 13, 2025
View reviewed changes
Copy link
Member

@dario-piotrowicz dario-piotrowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks @targos! 🫶

@targos targos changed the title [v24.x] repl: move completion logic to internal module [v24.x backport] repl: move completion logic to internal module Dec 14, 2025
@avivkeller avivkeller added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 19, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 19, 2025
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 19, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/70519/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 20, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/70542/

@avivkeller avivkeller added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jan 10, 2026
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 10, 2026
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 10, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/70751/

@dario-piotrowicz @targos
repl: move completion logic to internal module
e781d88 
PR-URL: nodejs#59889
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@targos targos force-pushed the backport-repl-v24 branch from 3961e22 to e781d88 Compare January 23, 2026 13:57
@targos
Copy link
Member Author

targos commented Jan 23, 2026

Simple rebase without conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@avivkeller avivkeller avivkeller approved these changes

@dario-piotrowicz dario-piotrowicz dario-piotrowicz approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. repl Issues and PRs related to the REPL subsystem. v24.x Issues that can be reproduced on v24.x or PRs targeting the v24.x-staging branch.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@targos @nodejs-github-bot @avivkeller @dario-piotrowicz