Skip to content

Conversation

@marco-ippolito
Copy link
Member

fixes weird formatting errors on the changelog due to the security release automation

@nodejs-github-bot nodejs-github-bot added the release Issues and PRs related to Node.js releases. label Jan 13, 2026
@marco-ippolito marco-ippolito changed the title Fix all release notes doc: fix changelog after security release Jan 13, 2026
@marco-ippolito marco-ippolito requested a review from a team January 13, 2026 14:57
@RafaelGSS RafaelGSS added fast-track PRs that do not need to wait for 48 hours to land. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. labels Jan 13, 2026
@github-actions
Copy link
Contributor

Fast-track has been requested by @RafaelGSS. Please 👍 to approve.

@marco-ippolito marco-ippolito added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 13, 2026
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jan 13, 2026
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/61371
✔  Done loading data for nodejs/node/pull/61371
----------------------------------- PR info ------------------------------------
Title      doc: fix changelog after security release (#61371)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     marco-ippolito:fix-all-release-notes -> nodejs:main
Labels     fast-track, release, commit-queue-rebase
Commits    4
 - doc: fix v20 changelog after security release
 - doc: fix v22 changelog after security release
 - doc: fix v24 changelog after security release
 - doc: fix v25 changelog after security release
Committers 1
 - Marco Ippolito <marcoippolito54@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/61371
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/61371
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Tue, 13 Jan 2026 14:55:34 GMT
   ✔  Approvals: 1
   ✔  - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/61371#pullrequestreview-3656360219
   ℹ  This PR is being fast-tracked
   ✘  This PR needs to wait 165 more hours to land (or 45 hours if there is one more approval) (or 0 hours if there is 1 more approval (👍) of the fast-track request from collaborators).
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/20967078419

src,lib:
* (CVE-2025-55131) refactor unsafe buffer creation to remove zero-fill toggle (Сковорода Никита Андреевич) <https://github.com/nodejs-private/node-private/pull/759>
tls:
* (CVE-2026-21637) route callback exceptions through error handlers (Matteo Collina) <https://github.com/nodejs-private/node-private/pull/796>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we want to keep the subsystem? It's harder to understand what the change is about without it

Suggested change
* (CVE-2026-21637) route callback exceptions through error handlers (Matteo Collina) <https://github.com/nodejs-private/node-private/pull/796>
* **(CVE-2026-21637)** **tls**: route callback exceptions through error handlers (Matteo Collina) <https://github.com/nodejs-private/node-private/pull/796>

Copy link
Member Author

@marco-ippolito marco-ippolito Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at previous security releases we dont iirc

@aduh95 aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Jan 13, 2026
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jan 14, 2026
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/61371
✔  Done loading data for nodejs/node/pull/61371
----------------------------------- PR info ------------------------------------
Title      doc: fix changelog after security release (#61371)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     marco-ippolito:fix-all-release-notes -> nodejs:main
Labels     fast-track, release, commit-queue-rebase
Commits    4
 - doc: fix v20 changelog after security release
 - doc: fix v22 changelog after security release
 - doc: fix v24 changelog after security release
 - doc: fix v25 changelog after security release
Committers 1
 - Marco Ippolito <marcoippolito54@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/61371
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/61371
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Tue, 13 Jan 2026 14:55:34 GMT
   ✔  Approvals: 4
   ✔  - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/61371#pullrequestreview-3656360219
   ✔  - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/61371#pullrequestreview-3657159376
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/61371#pullrequestreview-3658011944
   ✔  - Ulises Gascón (@UlisesGascon): https://github.com/nodejs/node/pull/61371#pullrequestreview-3658073699
   ℹ  This PR is being fast-tracked
   ✘  This PR needs to wait 39 more hours to land (or 0 hours if there is 1 more approval (👍) of the fast-track request from collaborators).
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/20977039224

@marco-ippolito marco-ippolito removed the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Jan 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. fast-track PRs that do not need to wait for 48 hours to land. release Issues and PRs related to Node.js releases.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants