Skip to content

Conversation

@mertcanaltin
Copy link
Member

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Jan 23, 2026
@mertcanaltin mertcanaltin marked this pull request as draft January 23, 2026 19:47
@codecov
Copy link

codecov bot commented Jan 23, 2026

Codecov Report

❌ Patch coverage is 62.50000% with 21 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.79%. Comparing base (ec56413) to head (0c17bf1).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/encoding_binding.cc 62.50% 16 Missing and 5 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #61496      +/-   ##
==========================================
- Coverage   89.80%   89.79%   -0.01%     
==========================================
  Files         672      672              
  Lines      203907   203955      +48     
  Branches    39202    39201       -1     
==========================================
+ Hits       183114   183138      +24     
- Misses      13115    13140      +25     
+ Partials     7678     7677       -1     
Files with missing lines Coverage Δ
src/encoding_binding.cc 52.96% <62.50%> (+0.22%) ⬆️

... and 27 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants