Make import work for BitBucket, CodeCommit and GitLab#617
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #617 +/- ##
==========================================
+ Coverage 73.22% 82.14% +8.91%
==========================================
Files 105 107 +2
Lines 12588 12724 +136
==========================================
+ Hits 9218 10452 +1234
+ Misses 3370 2272 -1098
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
…template for generic git provider
| ) | ||
|
|
||
| build_id = response["build"]["id"] | ||
| # FIXME explain why this is stalling for builds |
There was a problem hiding this comment.
FIXME okay to leave? Comment below still needed?
There was a problem hiding this comment.
context: this is a cicd script sitting in their build system. so I attempt to not import anything that requires another pip install.
I switch this to standard logging module in python standard library.
| GENERIC_GIT_PROVIDER_SECRET_ARN = os.environ.get("GENERIC_GIT_PROVIDER_SECRET_ARN") | ||
|
|
||
|
|
||
| def run_handler(event=None, context=None): |
There was a problem hiding this comment.
nit: This is code we'll need to maintain separately from the other Lambda? Is detect a v2 thing? Main concern is having to update lambda code in 2 places when we make any changes, but non-blocking.
There was a problem hiding this comment.
- detect will be a v2 thing.
- brutal refactor requires high test coverage. high test coverage takes time. it's open for discussion.
| @@ -0,0 +1,184 @@ | |||
| from __future__ import annotations | |||
There was a problem hiding this comment.
nit / non-blocking: Does this need to be an IAMbic plugin? If so, can we try to make it a standalone plugin so we can provide a reference architecture? The mono-repo approach and the v0_1_0 in path is some existing tech debt that we'll need to work our way around sooner or later.
There was a problem hiding this comment.
probably at least 2 day investment.
iambic/plugins/v0_1_0/generic_git_provider/generic_git_client.py
Outdated
Show resolved
Hide resolved
2 participants
What changed?
Rationale
How was it tested?
If it was manually verified, list the instructions for your reviewers to follow.
Run VSCode action: "Iambic: Simulate Generic Git Provider" with GIT_PROVIDER_UNDER_TEST with either
bitbucket,codecommit, orgitlab