Write exact directory when generating build file#6
Open
sticks-stuff wants to merge 1 commit intonosoop:masterfrom
Open
Write exact directory when generating build file#6sticks-stuff wants to merge 1 commit intonosoop:masterfrom
sticks-stuff wants to merge 1 commit intonosoop:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running build.ninja using the -f flag in ninja from any other directory other than the directory it was originally configured in fails as it can't find the referenced includes. For example:
This fixes that, but it might be worth hiding this behind another command line argument, like --portable, as it does make resulting build files look ugly.