Validate patch section and warn if patch bytes match binary#31
Closed
A1mDev wants to merge 5 commits intonosoop:masterfrom
A1mDev:verify-patch-bytes
Closed
Validate patch section and warn if patch bytes match binary#31A1mDev wants to merge 5 commits intonosoop:masterfrom A1mDev:verify-patch-bytes
A1mDev wants to merge 5 commits intonosoop:masterfrom
A1mDev:verify-patch-bytes
Conversation
- Added std::equal comparison to detect when patch bytes already match the binary. - Logs a clear message to the user indicating the patch is redundant, suggesting to verify patch data or check for conflicts with other plugins.
Contributor
Author
|
@nosoop Just checking in — could you please review or comment on this PR? If there’s no response, I’ll close it in a few days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #30