Skip to content

Conversation

@rzzf
Copy link
Contributor

@rzzf rzzf commented Feb 11, 2026

On the Package page, pressing the Comma shortcut navigates to the settings package(https://npmx.dev/package/settings) instead of the Settings configuration page.

@vercel
Copy link

vercel bot commented Feb 11, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Feb 11, 2026 4:11am
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Feb 11, 2026 4:11am
npmx-lunaria Ignored Ignored Feb 11, 2026 4:11am

Request Review

@codecov
Copy link

codecov bot commented Feb 11, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
app/components/AppHeader.vue 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 11, 2026

📝 Walkthrough

Walkthrough

In the AppHeader.vue component's onKeyStroke function, the navigation call for desktop links with keyboard shortcuts has been modified. When a matching keyboard shortcut is detected, navigateTo now receives link.to (the full route object) instead of link.to.name (the route name string). This single-line change alters the argument type passed to the navigation function from a string to an object, potentially affecting how the route resolution is handled downstream.

🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description clearly explains the issue being fixed: the Comma shortcut incorrectly navigates to a settings package page instead of the Settings configuration page. This directly relates to the code changes in AppHeader.vue.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

No actionable comments were generated in the recent review. 🎉


Comment @coderabbitai help to get the list of available commands and usage tips.

@antfu antfu added this pull request to the merge queue Feb 11, 2026
Merged via the queue into npmx-dev:main with commit d55dc9d Feb 11, 2026
17 checks passed
@rzzf rzzf deleted the fix/comma-to-settings branch February 11, 2026 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants