-
-
Notifications
You must be signed in to change notification settings - Fork 244
fix: position of icon in readme callouts #1418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
📝 WalkthroughWalkthroughThis pull request modifies the styling of callout elements in the Readme component. A left positioning property is added to the Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
app/components/Readme.vue (1)
288-295:⚠️ Potential issue | 🟡 MinorUse logical inset for RTL-safe positioning (Line 294).
left: 1remuses physical positioning that will misalign the icon in RTL layouts. Useinset-inline-start: 1remto maintain consistency with other logical properties in this component and ensure proper alignment across text directions. This property is supported in all modern browsers.Proposed diff
.readme :deep(blockquote[data-callout]::after) { content: ''; width: 1.25rem; height: 1.25rem; position: absolute; top: 1rem; - left: 1rem; + inset-inline-start: 1rem; }
serhalp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡
Fixes #1415
After: