-
-
Notifications
You must be signed in to change notification settings - Fork 244
chore: add .node-version and ignore .nvmrc
#1419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
📝 WalkthroughWalkthroughThe pull request updates Node.js version specifications across project configuration files. A 🚥 Pre-merge checks | ✅ 1✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 Comment |
|
I don't want to bikeshed this, but could we use the standard |
|
Unfortunately nvm does not. The issue is over a decade old. I would be fine to also add |
|
As far as I know, |
|
What do you use instead @RYGRIT? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've removed .nvmrc because I don't like non-standard config in the repo, and I do think there are better alternatives now, but I have added it to .gitignore so you can add your own .nvmrc without it getting committed automatically
.nvmrc and .node-version.node-version and ignore .nvmrc
Even |
|
I don't believe |
|
But unfortunately it's the one tool most people use. But the gitignore thing is fine for now. At least for me. |
.node-version shouldn't be a standard at all if I'm not wrong, nvmrc doesn't support it for example, but I totally agree with you, on a repo of mine, I replaced .nvmrc with .node-version |
This might be the single biggest change ever to npmx.
It allows to use
nvm useor automatic switching of Node version.We might also want to change
engineinpackage.jsonto24, instead of>=24, because I wouldn't optimistically want to switch to25(which isn't even a stable releaseor26`.