Skip to content

Conversation

@essenmitsosse
Copy link
Contributor

This might be the single biggest change ever to npmx.

It allows to use nvm use or automatic switching of Node version.

We might also want to change engine in package.json to 24, instead of >=24, because I wouldn't optimistically want to switch to 25 (which isn't even a stable releaseor26`.

@vercel
Copy link

vercel bot commented Feb 12, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Feb 12, 2026 4:12pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Feb 12, 2026 4:12pm
npmx-lunaria Ignored Ignored Feb 12, 2026 4:12pm

Request Review

@codecov
Copy link

codecov bot commented Feb 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 12, 2026

📝 Walkthrough

Walkthrough

The pull request updates Node.js version specifications across project configuration files. A .node-version file is created containing version 24. The package.json is modified to change the engines.node requirement from >=24 to 24. Additionally, .nvmrc is added to the .gitignore file's output section to exclude Node version manager files from version control. These changes consolidate version specification documentation within the project.

🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description accurately describes the changeset: adding Node version management files and updating the engines.node configuration.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

No actionable comments were generated in the recent review. 🎉


Comment @coderabbitai help to get the list of available commands and usage tips.

@serhalp
Copy link
Contributor

serhalp commented Feb 12, 2026

I don't want to bikeshed this, but could we use the standard .node-version instead? Pretty much all node version managers support it these days, don't they? (while .nvmrc is specific to nvm`)

@essenmitsosse
Copy link
Contributor Author

Unfortunately nvm does not. The issue is over a decade old. I would be fine to also add .node-version. It's annoying that everybody uses .node-version except for the most common version manager. Its a little overhead, but I think, since this will only be updated once a year, while making everyones life easier it's a fine trade-off.

@essenmitsosse essenmitsosse changed the title feat: add .nvmrc feat: add .nvmrc and .node-version Feb 12, 2026
@RYGRIT
Copy link
Contributor

RYGRIT commented Feb 12, 2026

As far as I know, .nvmrc does not work on Windows.😭

@ghostdevv
Copy link
Contributor

What do you use instead @RYGRIT?

Copy link
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed .nvmrc because I don't like non-standard config in the repo, and I do think there are better alternatives now, but I have added it to .gitignore so you can add your own .nvmrc without it getting committed automatically

@danielroe danielroe enabled auto-merge February 12, 2026 16:12
@danielroe danielroe changed the title feat: add .nvmrc and .node-version chore: add .node-version and ignore .nvmrc Feb 12, 2026
@danielroe danielroe added this pull request to the merge queue Feb 12, 2026
@lorypelli
Copy link
Contributor

I've removed .nvmrc because I don't like non-standard config in the repo, and I do think there are better alternatives now, but I have added it to .gitignore so you can add your own .nvmrc without it getting committed automatically

Even .node-version shouldn't be a standard and .nvmrc is more standard (if I'm not wrong)

Merged via the queue into npmx-dev:main with commit ff63e33 Feb 12, 2026
18 checks passed
@danielroe
Copy link
Member

I don't believe .nvmrc is more standard - it's the config file for one tool called nvm.

@essenmitsosse
Copy link
Contributor Author

But unfortunately it's the one tool most people use. But the gitignore thing is fine for now. At least for me.

@lorypelli
Copy link
Contributor

I don't believe .nvmrc is more standard - it's the config file for one tool called nvm.

.node-version shouldn't be a standard at all if I'm not wrong, nvmrc doesn't support it for example, but I totally agree with you, on a repo of mine, I replaced .nvmrc with .node-version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants