Speed up and clarify basis expansion#7
Open
jamesowers-roo wants to merge 1 commit intonumeristical:mainfrom
Open
Speed up and clarify basis expansion#7jamesowers-roo wants to merge 1 commit intonumeristical:mainfrom
jamesowers-roo wants to merge 1 commit intonumeristical:mainfrom
Conversation
Previous implementation was 4 functions deep. This implementation breaks the process into steps: make d, use d to make phi.
Contributor
Author
|
Are there any ways you would like this to be improved or changed? |
Contributor
|
Hey @jamesowers-roo - sorry I didn't see this until now. (I was away at a conference on May 11 so it must have gotten lost for me). Let me look it over. |
Contributor
|
Are/were you able to test this change? I am getting errors with the |
|
Ah, will do. Sorry I've only just seen this too (and have changed company since 🤣). I'll have a look at this when I find a moment, but it should be fairly straightforward (and for a decent speed up). I was doing this such that I could write something similar in a deep learning framework. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous implementation was 4 functions deep. This implementation breaks the process into steps: make d, use d to make phi. It should be faster because we're taking advantage of numpy's vectorized operations.