Timezone Support & Several Other Fixes#28
Conversation
|
There have been a ton of changes recently and this no longer merges properly. If the merge is fixed, I'll be happy to merge this in. |
|
This pull request can be accepted instead of #43; this fixes that issue. I don't think it's possible to add this functionality without merge conflicts; the few breaking changes are necessary and also improvements wrt to time zone updates. |
|
If someone gets this merge-able, I'll merge it. It'll probably require a pull from origin... Or even a re-application of changes from the current master. |
|
I attempted--I did a pull of the most recent and applied these changes and got the same results. |
|
Yeah, the last commit to that repo was in 2015 (honestly, I forgot I made this project). It either needs to be updated with more current code, or the timezone stuff needs to be re-implemented in a fresh branch. |
|
| //TODO add time and time zone? use moment to format? | ||
| var start_date = new Date(begin); | ||
| var end_date = new Date(stop); | ||
| var offset = new Date().getTimezoneOffset(); |
There was a problem hiding this comment.
This calculation can be incorrect due to Daylight Saving Time (DST)
Adds support for timezones so will set time properly. Also included several other fixes that were previously mentioned to make setting time in calendar invite function properly.