Skip to content

Conversation

@pajowu
Copy link
Member

@pajowu pajowu commented Nov 12, 2025

If the pdf_file is set (for example because the document pdf needed to be rewritten and get_writeable_file was called), it will take precedence over the attachments pdf. This means that new redactions applied to the attachment after pdf_file is set are not shown in the document, as the old version from pdf_file is still used for generating the pages etc.

If the pdf_file is set (for example because the document pdf needed to be rewritten and get_writeable_file was called), it will take precedence over the attachments pdf. This means that new redactions applied to the attachment after pdf_file is set are not shown in the document, as the old version from pdf_file is still used for generating the pages etc.
@pajowu pajowu requested a review from stefanw November 12, 2025 10:46
Copy link
Member

@stefanw stefanw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not recall when I introduced get_writeable_file. I thought the concept of original and pdf_file in filingcabinet where mutually exclusive. I thought if there's an original like an attachment, there would be no other stored document. I guess there can be edge cases where you do need one, but I'm a bit concerned that there's logic in filingcabinet that will ignore pdf_file when original is still set – or that when it's not set but there should be a related model. Obviously, that is nothing that can be fixed in froide. If this signal processor helps, let's go!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants