feat: introduce ooni-geoip private bucket for geoip database files #323
+161
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Terraform Run Output 🤖Format and Style 🖌
|
| Pusher | @DecFox |
| Action | pull_request |
| Environment | dev |
| Workflow | .github/workflows/check_terraform.yml |
| Last updated | Mon, 02 Feb 2026 11:05:45 GMT |
4 tasks
LDiazN
reviewed
Feb 2, 2026
| Statement = [ | ||
| { | ||
| Effect = "Allow" | ||
| Action = [ |
Contributor
There was a problem hiding this comment.
I would make the permission set a parameter, this is too permissive. You can set it to ["s3:*"] by default but there should be a way to specify permissions
LDiazN
reviewed
Feb 2, 2026
|
|
||
| policy = jsonencode({ | ||
| Version = "2012-10-17" | ||
| Statement = [ |
Contributor
There was a problem hiding this comment.
The permissions here are ok but I would still make the permission set a parameter that defaults to this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This diff introduces a new
ooni-geoips3 bucket which will be used to store geoip db files. This is part of ooni/historical-geoip#22