-
Notifications
You must be signed in to change notification settings - Fork 3
feat: add support for multilingual UI #1479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
staceybeard
wants to merge
32
commits into
main
Choose a base branch
from
SB.multilingual-UI
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/js/controllers/home/homeController.js
1 task
mschoettle
approved these changes
Jan 20, 2026
Member
mschoettle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
Member
Author
Thanks @mschoettle! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this merge request, I confirm the following:
Backendproject'sREADME.md)feat: minor app version will be incremented.fix,deps,perf: patch app version will be incremented.chore,ci, etc.: app version will not be incremented.for complete set of rules.
Changes
Updated code across the app to support a truly multilingual UI.
While
angular-translatewas already set up to facilitate adding more languages, the app's controllers and views still expected data to be provided in either English or French. This meant that setting the app to a new language would break the majority of the data display. The PR linked below moves the responsibility to the listener to provide translated strings and data, with a fallback language when the requested language isn't available. This allows the app to receive and display data in any language, and allows the user to set the UI to a language other than English or French.The following example describes the most common change required for a multilingual UI. Suppose a piece of data has a description; the data would come from the listener with fields
Description_ENandDescription_FR. The app view would then displayDescription_${language}. However, with the app in Spanish (for example), the view would be trying to accessDescription_ES, which doesn't exist. To fix this problem, the code was changed to expect just aDescription, already translated by the listener either in the correct language or a fallback language.Extra changes:
src/views/personal/documents/pdf-view.html. Then renamedpdf-view.directive.csstopdf-viewer.directive.cssfor clarity.@babel/plugin-proposal-throw-expressionsto allow the syntaxreturn data || throw error;(used indynamicContentService.jswhen a link is missing in the chosen language and in the fallback language).Dependencies
Screenshots
The following languages are provided as an example.