openWB SE

[LKuemmel]

• SE
• Duo
• Pro Plus
• Buchse

[Copilot]

Pull request overview

This PR updates internal openWB chargepoint handling to support the “SE” variant by introducing SE-specific EVSE Modbus IDs and moving internal mode handling toward InternalChargepointMode enums, plus adjusts the standalone Modbus read/write helper scripts.

Changes:

• Add SE-specific EVSE Modbus IDs and thread mode into the internal Modbus client selection.
• Update InternalChargepointHandler logic to compare enums directly and pass mode into client creation.
• Modify runs/evse_read_modbus.py and runs/evse_write_modbus.py to open a serial port via /dev/serial/by-path.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File	Description
runs/evse_write_modbus.py	Switches helper script to directly open a serial device from /dev/serial/by-path and write with a caller-provided Modbus unit.
runs/evse_read_modbus.py	Switches helper script to directly open a serial device from /dev/serial/by-path and read with a caller-provided Modbus unit.
packages/modules/internal_chargepoint_handler/internal_chargepoint_handler.py	Uses InternalChargepointMode enum comparisons and passes mode into client creation for SE handling.
packages/modules/internal_chargepoint_handler/clients.py	Introduces SE-specific EVSE IDs and adds mode parameter to Modbus client selection / factory.

Comments suppressed due to low confidence (1)

packages/modules/internal_chargepoint_handler/clients.py:152

• In the counter > 1 branch, evse_ids are always set to EVSE_ID_CP0 / EVSE_ID_TWO_BUSSES_CP1 regardless of mode. If SE uses different Modbus IDs (as introduced above), this branch should also pick SE-specific IDs based on mode (and possibly CP0/CP1).

        with ModifyLoglevelContext(log, logging.DEBUG):
            log.debug("found "+str(counter)+" possible usb devices: "+str(resolved_devices))
        if local_charge_point_num == 0:
            meters = CP0_METERS
            evse_ids = EVSE_ID_CP0
        else:
            meters = CP1_METERS
            evse_ids = EVSE_ID_TWO_BUSSES_CP1

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.