[Accton][AS4630-54pe/te] Support 2nd source PSU#1019
Open
roger530-ho wants to merge 1 commit intoopencomputeproject:masterfrom
Open
[Accton][AS4630-54pe/te] Support 2nd source PSU#1019roger530-ho wants to merge 1 commit intoopencomputeproject:masterfrom
roger530-ho wants to merge 1 commit intoopencomputeproject:masterfrom
Conversation
roger530-ho
force-pushed
the
add_new_psu_for_as4630_54pe_54te
branch
from
fb0b780 to
78e0fbc
Compare
paulmenzel
suggested changes
Feb 21, 2025
paulmenzel
left a comment
paulmenzel
left a comment
There was a problem hiding this comment.
Thank you for your patch.
Please do git commit --amend and elaborate in the commit message description some more, how you implemented the second PSU source.
Signed-off-by: roger530_ho roger530_ho@accton.com
Please also use your full name.
$ git config --global user.name "Your Name"
$ git commit --amend --author="Your Name <roger530_ho@accton.com>"
paulmenzel
reviewed
Feb 21, 2025
|
|
||
| struct model_name_info models[] = { | ||
| {PSU_YPEB1200, 0x20, 11, "YPEB1200"}, | ||
| {PSU_YPEB1200AM, 0x20, 11, "YPEB1200AM"}, /* Replace YPEB1200-AM to YPEB1200AM */ |
Author
There was a problem hiding this comment.
This is due to the original design, which shifts one character forward from 'AM'.
packages/platforms/accton/x86-64/as4630-54pe/modules/builds/x86-64-accton-as4630-54pe-psu.c
Outdated
Show resolved
Hide resolved
packages/platforms/accton/x86-64/as4630-54te/modules/builds/x86-64-accton-as4630-54te-psu.c
Outdated
Show resolved
Hide resolved
packages/platforms/accton/x86-64/as4630-54te/modules/builds/x86-64-accton-as4630-54te-psu.c
Outdated
Show resolved
Hide resolved
packages/platforms/accton/x86-64/as4630-54pe/modules/builds/x86-64-accton-as4630-54pe-psu.c
Outdated
Show resolved
Hide resolved
roger530-ho
force-pushed
the
add_new_psu_for_as4630_54pe_54te
branch
from
78e0fbc to
3b805bc
Compare
Signed-off-by: Roger Ho <roger530_ho@accton.com>
roger530-ho
force-pushed
the
add_new_psu_for_as4630_54pe_54te
branch
from
3b805bc to
3a9ea39
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modify PSU related files to support 2nd source PSU.
AS4630-54PE : UP1K21R-1085G (F2B)
AS4630-54TE : UPD1501SA-1190G (F2B), UPD1501SA-1290G(B2F)