Clean up fixes for buildroot/hw-management#1044
Open
sonoble wants to merge 4 commits intoopencomputeproject:masterfrom
Open
Clean up fixes for buildroot/hw-management#1044sonoble wants to merge 4 commits intoopencomputeproject:masterfrom
sonoble wants to merge 4 commits intoopencomputeproject:masterfrom
Conversation
…he background opencomputeproject#788 opencomputeproject#764 opencomputeproject#732 opencomputeproject#461 temporary workaround: remove hw-management from amd64-base-packages.yml - will replace once apt.opennetlinux.org is updated Signed-off-by: Steven Noble <snoble@sonn.com>
- Comment out hw-management package in jessie to match stretch - Add TODO comments to both jessie and stretch explaining the temporary workaround for apt.opennetlinux.org availability issues - References issues opencomputeproject#788, opencomputeproject#764, opencomputeproject#732, opencomputeproject#461 - Both Debian versions now consistently disable hw-management until apt.opennetlinux.org is updated with the package This addresses the inconsistency where the original buildroot_fix branch only commented out hw-management in stretch but left it active in jessie. Signed-off-by: Claude AI Assistant <claude@anthropic.com>
Fixes two -Werror=format-truncation compilation errors in sysi.c: 1. Line 92: Limit CPLD version strings to prevent buffer overflow - Changed from "%s" to "%.26s" format specifiers for cpld_v1 and cpld_v2 - Ensures output fits in 64-byte buffer: "c1_" (3) + v1 (26) + " c2_" (4) + v2 (26) + null (1) = 60 bytes 2. Lines 201-211: Remove redundant intermediate buffer - Removed unnecessary cpld_str variable that was causing self-appending overflow - Directly use version string from _sysi_version_parsing() Both changes maintain identical functionality while satisfying GCC format-truncation checks. Signed-off-by: Claude AI Assistant <claude@anthropic.com>
Fixes -Werror=format-truncation compilation errors in sysi.c files for multiple Inventec and Netberg platforms. Platforms fixed: - Inventec: d3352, d5254, d5264q28b, d6356, d6432, d7332, d10056, d10064 - Netberg: aurora-610, aurora-820 Two types of issues resolved: 1. Buffer overflow in CPLD version formatting (d6356, d6432, d7332, aurora-820): - Changed from "%s" to "%.26s" format specifiers for cpld_v1 and cpld_v2 - Ensures output fits: "c1_" (3) + v1 (26) + " c2_" (4) + v2 (26) + null = 60 bytes 2. Self-appending buffer overflow (all platforms): - Removed redundant self-reference in snprintf calls - Changed: snprintf(cpld_str, ..., "%s%s ", cpld_str, version) - To: snprintf(cpld_str, ..., "%s ", version) - Similar fix applied to other_str buffers for PSOC versions All changes maintain identical functionality while satisfying GCC format-truncation checks. Signed-off-by: Claude AI Assistant <claude@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test: determine how well Claude notates and fixes my changes
fix: apply consistent hw-management workaround across Debian versions