Conversation
|
Thanks for the pull request, @felipemontoya! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #140 +/- ##
=======================================
Coverage 91.22% 91.22%
=======================================
Files 51 51
Lines 4547 4549 +2
Branches 276 276
=======================================
+ Hits 4148 4150 +2
Misses 311 311
Partials 88 88
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR improves the reliability and readability of the Open edX component extractor utilities, primarily by avoiding import-time access to a potentially-missing Django setting and by cleaning up string/log formatting.
Changes:
- Lazily fetch
AI_EXTENSIONS_FIELD_FILTERSvia a helper to prevent import-time failures and to allow tests/runtime overrides to take effect. - Refactor embedded-content extraction strings and logging calls for cleaner formatting and consistency.
- Reformat a few list literals / comprehensions for readability.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| filters = _get_field_filters() | ||
| allowed_fields = filters.get("allowed_fields", []) | ||
| allowed_field_substrings = filters.get("allowed_field_substrings", []) |
There was a problem hiding this comment.
_get_field_filters() can return a non-dict value (e.g., None or a misconfigured setting), but _is_field_allowed() assumes a mapping and lists. This will raise at runtime when calling .get() or doing fname in allowed_fields. Consider normalizing here (e.g., filters = getattr(..., None) or {} and verify isinstance(filters, dict); similarly coerce missing/None allowed lists to empty lists) so field extraction degrades safely under misconfiguration.
This pull request improves the quality of the structure function of it. I found this while working on something else and I decided to commit it in its own PR.