Skip to content

Conversation

@rodmgwgu
Copy link
Contributor

@rodmgwgu rodmgwgu commented Jan 30, 2026

This PR adds an ADR specifying the overall implementation strategy for AuthZ for Course Authoring, including:

  • Documentation on known technical debt that affects this effort
  • Decision on not tackling that technical debt at this stage, but keep track of it for future efforts
  • How and where the new permissions will be implemented
  • How the feature will be enabled via a feature flag
  • How data migration between the authz systems will be handled
  • A note on the compatibility layer to be implemented

Further details on the feature flags and migration process will be defined in additional ADRs.

Related issue: #184

Merge checklist:
Check off if complete or not applicable:

  • Version bumped
  • Changelog record added
  • Documentation updated (not only docstrings)
  • Fixup commits are squashed away
  • Unit tests added/updated
  • Manual testing instructions provided
  • Noted any: Concerns, dependencies, migration issues, deadlines, tickets

@openedx-webhooks openedx-webhooks added open-source-contribution PR author is not from Axim or 2U core contributor PR author is a Core Contributor (who may or may not have write access to this repo). labels Jan 30, 2026
@openedx-webhooks
Copy link

openedx-webhooks commented Jan 30, 2026

Thanks for the pull request, @rodmgwgu!

This repository is currently maintained by @openedx/committers-openedx-authz.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

…Authoring

docs: add ADR for overall strategy for implementing AuthZ for Course Authoring
@rodmgwgu rodmgwgu marked this pull request as ready for review February 3, 2026 20:39
the same approach used for Libraries.
* Course authoring permission enforcement using the new system will be optionally enabled via a
feature flag.
* The feature flag can be enabled instance-wide or for specific courses.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we not doing an org-wide flag for this phase? I'm not opposed, just want it to be explicit one way or the other.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this has been specified here: #212

This phase focuses on migrating course authoring permissions while maintaining current
functionality.

* **Migration Script**: Transform existing role assignments into the new authorization model
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we going to support a version of this that works based on changes in the Django admin? That interface is available for people to add waffle flags, so if that make that change without using the script we would be in a place of trying to us RBAC without the permissions being migrated.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is further specified here: #213

Copy link
Contributor

@bmtcril bmtcril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of questions for clarity

@mphilbrick211 mphilbrick211 added the mao-onboarding Reviewing this will help onboard devs from an Axim mission-aligned organization (MAO). label Feb 3, 2026
@mphilbrick211 mphilbrick211 moved this from Needs Triage to Ready for Review in Contributions Feb 3, 2026
@mphilbrick211 mphilbrick211 moved this from Ready for Review to In Eng Review in Contributions Feb 3, 2026

A rollback migration process will also be provided to revert from openedx-authz roles back to
legacy roles if the feature flag is disabled. The rollback will only support roles with exact
equivalences between systems; non-equivalent roles will be ignored with warnings logged to the

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the expected behavior in this scenario?

When the feature flag is enabled, a migration script is expected to run, and when it is disabled, a rollback is expected to be executed. Is this correct?

If the feature flag is enabled again later by an authorized user, will the migration scripts run again?

This is to clarify whether this behavior should be documented here or covered in separate migration or operational documentation.

Also, is it worth mentioning that operators are the ones who can enable or disable this flag?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback, I added those details in this other ADR: #212

the flag will be managed either from the Django Admin (superusers), or via a management commant (operators)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rodmgwgu

Copy link
Contributor

@sarina sarina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Broadly I think this looks great. I'm wondering if we'd want to have specific release dates/timelines in here (ie what we're targeting for Verawood, that the deprecation is aimed for Xylon, etc)

Copy link
Contributor

@wgu-taylor-payne wgu-taylor-payne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks good to me. I don't have any unique feedback to add.

Copy link

@dwong2708 dwong2708 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

Copy link
Contributor

@bmtcril bmtcril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think my questions were answered in the other ADR 👍

@rodmgwgu rodmgwgu merged commit 805008d into openedx:main Feb 5, 2026
14 checks passed
@github-project-automation github-project-automation bot moved this from In Eng Review to Done in Contributions Feb 5, 2026
@rodmgwgu rodmgwgu deleted the rod/adr-phase2 branch February 5, 2026 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). mao-onboarding Reviewing this will help onboard devs from an Axim mission-aligned organization (MAO). open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

7 participants