-
Notifications
You must be signed in to change notification settings - Fork 4.2k
feat: implement instructor API v2 grading GET endpoints #37890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat: implement instructor API v2 grading GET endpoints #37890
Conversation
|
Thanks for the pull request, @brianjbuck-wgu! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
a143cc2 to
7cfdc7a
Compare
8bdff7a to
dcc4052
Compare
dcc4052 to
a26adc7
Compare
| def setUp(self): | ||
| super().setUp() | ||
| self.client = APIClient() | ||
| self.instructor = UserFactory(is_staff=False) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might need something like the snippet above to avoid patching in every test:
self.instructor = InstructorFactory.create(course_key=self.course_key)
| 'email': student.email, | ||
| 'first_name': student.first_name, | ||
| 'last_name': student.last_name, | ||
| 'progress_url': None, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are the None values intentional?
| 'attempts': None, | ||
| } | ||
|
|
||
| from .serializers_v2 import LearnerSerializer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move this import into the proper import section
Summary
This PR implements three new GET endpoints for the Instructor Dashboard API v2 grading operations, as specified in the OpenAPI schema from #37743.
New Endpoints:
GET /api/instructor/v2/courses/{course_id}/learners/{email_or_username}
GET /api/instructor/v2/courses/{course_id}/problems/{location}
GET /api/instructor/v2/courses/{course_id}/tasks/{task_id}
All endpoints follow existing instructor API v2 patterns with proper authentication, permission checks, and error handling.