413 feature improve connection of charging points#421
Open
Conversation
birgits
reviewed
Sep 13, 2024
birgits
reviewed
Sep 13, 2024
birgits
reviewed
Sep 13, 2024
birgits
reviewed
Sep 13, 2024
birgits
reviewed
Sep 13, 2024
birgits
reviewed
Sep 13, 2024
birgits
reviewed
Sep 13, 2024
birgits
reviewed
Sep 13, 2024
birgits
reviewed
Sep 13, 2024
birgits
reviewed
Sep 13, 2024
birgits
reviewed
Sep 13, 2024
| logger.error(f"Component type {comp_type} is not a valid option.") | ||
| return | ||
| elif comp_type in ["generator", "storage_unit"]: | ||
| comp_data["p_nom"] = comp_data["p"] |
There was a problem hiding this comment.
Why do you need this? Above, p is set, so that all have p. Setting both seems redundant.
|
@joda9 some tests are failing now because I used your new function geo.calculate_distance_to_buses_df() in geo.find_nearest_bus(). I don't get, why it would change the calculated distance, because geopy.distance.distance uses geodesic, which was used before in geo.find_nearest_bus(). Also, changing distance.distance to distance.geodesic didn't fix the problem. So it must be something else that's different in your function. Could you try to find out, what it is? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This update enhances the
connect_to_lv_based_on_geolocationfunction with the following improvements:Charging Point Connection:
Load Distribution Across Buses:
MV Bus Connection:
Updated Documentation:
Fixes #413
Type of change
Please delete options that are not relevant.
Bug fix (non-breaking change which fixes an issue)Checklist:
pre-commithooksIf new packages are needed, I added them the setup.py, and if needed the rtd_requirements.txt, the eDisGo_env.yml and the eDisGo_env_dev.yml.