-
-
Notifications
You must be signed in to change notification settings - Fork 211
[ENH] added version flag to openml cli #1555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
jgyasu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I am not sure if CLI is tested or not currently, but can you please add a test for this?
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1555 +/- ##
==========================================
- Coverage 53.02% 52.01% -1.02%
==========================================
Files 36 36
Lines 4326 4328 +2
==========================================
- Hits 2294 2251 -43
- Misses 2032 2077 +45 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
geetu040
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a comment on tests, otherwise openml/cli.py looks good.
geetu040
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done. LGTM!
CC: @fkiraly, @SimonBlanke for review/merge.
Fixes #1539