-
-
Notifications
You must be signed in to change notification settings - Fork 211
[ENH] Extend Extension class test suite
#1560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1560 +/- ##
==========================================
- Coverage 53.02% 52.72% -0.31%
==========================================
Files 36 36
Lines 4326 4326
==========================================
- Hits 2294 2281 -13
- Misses 2032 2045 +13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Error seems unrelated to the PR given all this PR does is extend the Edit: The tests pass locally. |
jgyasu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I think we can merge this even if the the Extension is planned to be refactored.
Metadata
Details
This PR adds unit tests for the OpenML Extension interface and for extension registry behavior. The tests added are the 7 tests mentioned in [ENH] Extension Module Tests (or Examples?) #1545
Previously, only the non-abstract registry helpers (
get_extension_by_model,get_extension_by_flow) were covered. The abstractExtensioninterface itself was not tested.