Migrate Apache HttpAsyncClient 4.x to HttpClient 5.x #117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tConnectionManager` using its builder Still to do: - Migrating more complicated constructors - Handling other classes from the Http Async Client dependency
…nnectionManager` were to call out cases where constructor migration will lose parameters that need to be double checked. Moving some migrations into the set of HttpCore-Nio class migrations
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
...main/java/org/openrewrite/apache/httpclient5/MigratePoolingNHttpClientConnectionManager.java
Outdated
Show resolved
Hide resolved
...main/java/org/openrewrite/apache/httpclient5/MigratePoolingNHttpClientConnectionManager.java
Outdated
Show resolved
Hide resolved
...main/java/org/openrewrite/apache/httpclient5/MigratePoolingNHttpClientConnectionManager.java
Outdated
Show resolved
Hide resolved
...main/java/org/openrewrite/apache/httpclient5/MigratePoolingNHttpClientConnectionManager.java
Outdated
Show resolved
Hide resolved
...n/java/org/openrewrite/apache/httpclient5/UsePoolingAsyncClientConnectionManagerBuilder.java
Show resolved
Hide resolved
...n/java/org/openrewrite/apache/httpclient5/UsePoolingAsyncClientConnectionManagerBuilder.java
Outdated
Show resolved
Hide resolved
...n/java/org/openrewrite/apache/httpclient5/UsePoolingAsyncClientConnectionManagerBuilder.java
Outdated
Show resolved
Hide resolved
...n/java/org/openrewrite/apache/httpclient5/UsePoolingAsyncClientConnectionManagerBuilder.java
Outdated
Show resolved
Hide resolved
...va/org/openrewrite/apache/httpclient5/UsePoolingAsyncClientConnectionManagerBuilderTest.java
Outdated
Show resolved
Hide resolved
…of what's sitll left.
steve-aom-elliott
force-pushed
the
steve/1529-apache-http-async-client-migration
branch
from
0af2eac to
6a385ff
Compare
...main/java/org/openrewrite/apache/httpclient5/MigratePoolingNHttpClientConnectionManager.java
Outdated
Show resolved
Hide resolved
...main/java/org/openrewrite/apache/httpclient5/MigratePoolingNHttpClientConnectionManager.java
Outdated
Show resolved
Hide resolved
...main/java/org/openrewrite/apache/httpclient5/MigratePoolingNHttpClientConnectionManager.java
Outdated
Show resolved
Hide resolved
...main/java/org/openrewrite/apache/httpclient5/MigratePoolingNHttpClientConnectionManager.java
Outdated
Show resolved
Hide resolved
...n/java/org/openrewrite/apache/httpclient5/UsePoolingAsyncClientConnectionManagerBuilder.java
Show resolved
Hide resolved
...n/java/org/openrewrite/apache/httpclient5/UsePoolingAsyncClientConnectionManagerBuilder.java
Outdated
Show resolved
Hide resolved
...n/java/org/openrewrite/apache/httpclient5/UsePoolingAsyncClientConnectionManagerBuilder.java
Outdated
Show resolved
Hide resolved
...n/java/org/openrewrite/apache/httpclient5/UsePoolingAsyncClientConnectionManagerBuilder.java
Outdated
Show resolved
Hide resolved
...va/org/openrewrite/apache/httpclient5/UsePoolingAsyncClientConnectionManagerBuilderTest.java
Outdated
Show resolved
Hide resolved
steve-aom-elliott
added
bug
...main/java/org/openrewrite/apache/httpclient5/MigratePoolingNHttpClientConnectionManager.java
Outdated
Show resolved
Hide resolved
...main/java/org/openrewrite/apache/httpclient5/MigratePoolingNHttpClientConnectionManager.java
Outdated
Show resolved
Hide resolved
...main/java/org/openrewrite/apache/httpclient5/MigratePoolingNHttpClientConnectionManager.java
Outdated
Show resolved
Hide resolved
…syncClientConnectionManager` and its builder respectively. Updated `closeIdleConnections(..)` to `closeIdle(..)`
src/main/java/org/openrewrite/apache/httpclient5/ChangeArgumentToTimeValue.java
Show resolved
Hide resolved
...main/java/org/openrewrite/apache/httpclient5/MigratePoolingNHttpClientConnectionManager.java
Outdated
Show resolved
Hide resolved
...main/java/org/openrewrite/apache/httpclient5/MigratePoolingNHttpClientConnectionManager.java
Outdated
Show resolved
Hide resolved
...main/java/org/openrewrite/apache/httpclient5/MigratePoolingNHttpClientConnectionManager.java
Outdated
Show resolved
Hide resolved
src/main/java/org/openrewrite/apache/httpclient5/ChangeArgumentToTimeValue.java
Show resolved
Hide resolved
...main/java/org/openrewrite/apache/httpclient5/MigratePoolingNHttpClientConnectionManager.java
Outdated
Show resolved
Hide resolved
...main/java/org/openrewrite/apache/httpclient5/MigratePoolingNHttpClientConnectionManager.java
Outdated
Show resolved
Hide resolved
...main/java/org/openrewrite/apache/httpclient5/MigratePoolingNHttpClientConnectionManager.java
Outdated
Show resolved
Hide resolved
...main/java/org/openrewrite/apache/httpclient5/MigratePoolingNHttpClientConnectionManager.java
Outdated
Show resolved
Hide resolved
...main/java/org/openrewrite/apache/httpclient5/MigratePoolingNHttpClientConnectionManager.java
Outdated
Show resolved
Hide resolved
...main/java/org/openrewrite/apache/httpclient5/MigratePoolingNHttpClientConnectionManager.java
Outdated
Show resolved
Hide resolved
steve-aom-elliott
requested review from
Jenson3210,
MBoegers,
dsgrieve and
timtebeek
jkschneider
approved these changes
Feb 4, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
PoolingNHttpClientConnectionManagertoPoolingAsyncClientConnectionManagerusing the builder patternhttpcore-nioclasses tohttpcore5equivalentsProblem
Apache HttpAsyncClient 4.x is deprecated and customers need to migrate to HttpClient 5.x. The
PoolingNHttpClientConnectionManagerclass and related NIO classes have changed significantly in the new version.Solution
New recipes added:
MigratePoolingNHttpClientConnectionManager- Converts constructor calls to usePoolingAsyncClientConnectionManagerBuilder.create().build()UsePoolingAsyncClientConnectionManagerBuilder- Folds subsequent configuration method calls into the builder chain, with method name mappings (e.g.,setMaxTotal→setMaxConnTotal)UpgradeApacheHttpClient_5_AsyncClientClassMapping- Orchestrates async client class migrationsRecipes updated:
UpgradeApacheHttpCore_5_NioClassMapping- Migrates additionalhttpcore-nioclassesTest plan
Existing tests pass
New tests added for
MigratePoolingNHttpClientConnectionManagerNew tests added for
UsePoolingAsyncClientConnectionManagerBuilderNew tests added for
MigrateApacheHttpCoreNioTestFixes moderneinc/customer-requests#1529