Improve coderabbit config #5048
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tomoyuki Morita <moritato@amazon.com>
ykmr1224
requested review from
GumpacG,
LantaoJin,
MaxKsyunz,
RyanL1997,
Swiddis,
YANG-DB,
Yury-Fridlyand,
acarbonetto,
anirudha,
dai-chen,
derek-ho,
forestmvey,
joshuali925,
kavithacm,
mengweieric,
noCharger,
penghuo,
ps48,
qianheng-aws,
seankao-az,
vamsimanohar and
yuancu
as code owners
Contributor
📝 WalkthroughSummary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings. WalkthroughReplaces and centralizes review guidance: updates Changes
Sequence Diagram(s)(omitted) Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
LantaoJin
added
the
infrastructure
dai-chen
reviewed
Jan 15, 2026
Collaborator
dai-chen
left a comment
dai-chen
left a comment
There was a problem hiding this comment.
Just curious are these new tenets collected / summarized from somewhere?
Signed-off-by: Tomoyuki Morita <moritato@amazon.com>
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In @.coderabbit.yaml:
- Around line 161-172: The tone_instructions entry is currently an array and
misplaced; change it to a single top-level string under the key
tone_instructions (not nested under reviews) and condense the content to one
clear sentence <=250 characters; update the existing array value (referenced as
tone_instructions) to a single-line string that summarizes the most important
directives (conciseness, focus on functional issues, avoid repeated suggestions)
so the schema accepts it.
.coderabbit.yaml
Outdated
Comment on lines
161
to
172
| # Tone instructions to reduce noise | ||
| tone_instructions: | ||
| - "Be concise and focus on functional issues, not cosmetic ones" | ||
| - "Do NOT suggest minor refactorings unless the code is clearly problematic (>100 lines, deeply nested, etc.)" | ||
| - "Do NOT flag missing JavaDoc on test methods, test helpers, or private methods" | ||
| - "Do NOT suggest loading test data from files if inline data is clearer" | ||
| - "Do NOT flag NDJSON format as invalid JSON" | ||
| - "Do NOT suggest adding language identifiers to markdown code blocks unless it's a documentation file" | ||
| - "Prioritize: correctness > performance > maintainability > style" | ||
| - "When suggesting improvements, explain WHY, not just WHAT" | ||
| - "Do NOT repeat the same suggestion multiple times in a review" | ||
|
|
Contributor
There was a problem hiding this comment.
Fix tone_instructions schema violations (wrong location + type + length).
Schema requires a top‑level string (max 250 chars). The current array under reviews will be ignored or rejected.
✅ Suggested fix (move to top‑level and condense)
language: "en-US"
early_access: false
+tone_instructions: "Be concise; focus on functional issues. Avoid minor refactors unless >100 lines or deeply nested. Prioritize correctness>performance>maintainability>style. Avoid duplicate suggestions."
reviews:
profile: "chill"
@@
- # Tone instructions to reduce noise
- tone_instructions:
- - "Be concise and focus on functional issues, not cosmetic ones"
- - "Do NOT suggest minor refactorings unless the code is clearly problematic (>100 lines, deeply nested, etc.)"
- - "Do NOT flag missing JavaDoc on test methods, test helpers, or private methods"
- - "Do NOT suggest loading test data from files if inline data is clearer"
- - "Do NOT flag NDJSON format as invalid JSON"
- - "Do NOT suggest adding language identifiers to markdown code blocks unless it's a documentation file"
- - "Prioritize: correctness > performance > maintainability > style"
- - "When suggesting improvements, explain WHY, not just WHAT"
- - "Do NOT repeat the same suggestion multiple times in a review"🤖 Prompt for AI Agents
In @.coderabbit.yaml around lines 161 - 172, The tone_instructions entry is
currently an array and misplaced; change it to a single top-level string under
the key tone_instructions (not nested under reviews) and condense the content to
one clear sentence <=250 characters; update the existing array value (referenced
as tone_instructions) to a single-line string that summarizes the most important
directives (conciseness, focus on functional issues, avoid repeated suggestions)
so the schema accepts it.
Collaborator
There was a problem hiding this comment.
According to coderabbit doc, tone_instructions should be a string less than 250 characters under the root level.
AI gave the following recommendations:
- Move
tone_instructionsto root level and consolidate into a single string (max 250 chars)
If want to keep it as a list
- Use
path_instructionswith a catch-all pattern - Put them in your
.rules/REVIEW_GUIDELINES.mdfile
RyanL1997
reviewed
Jan 16, 2026
.coderabbit.yaml
Outdated
| # Tone instructions to reduce noise | ||
| tone_instructions: | ||
| - "Be concise and focus on functional issues, not cosmetic ones" | ||
| - "Do NOT suggest minor refactorings unless the code is clearly problematic (>100 lines, deeply nested, etc.)" |
Collaborator
There was a problem hiding this comment.
>100 lines
What is this referring to? Like more than 100 lines for a single function or when the diff is more than 100 lines it start considering giving some refactoring suggestions?
dai-chen
previously approved these changes
Jan 20, 2026
Signed-off-by: Tomoyuki Morita <moritato@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
General review instructionssince it was not valid config in coderabbit.ymlRelated Issues
n/a
Check List
--signoffor-s.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.