OCPBUGS-66247: make cloudCredentials optional so operators load when …

[rhamilto]

…cloudCredential isn't present on the cluster

Tested against CRC version: 2.57.0+ae41f6 and Operators now display in Software Catalog.

Screen.Recording.2025-12-03.at.11.36.52.AM.mov

[openshift-ci-robot]

@rhamilto: This pull request references Jira Issue OCPBUGS-66247, which is invalid:

• expected the bug to target the "4.21.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

…cloudCredential isn't present on the cluster

Tested against CRC version: 2.57.0+ae41f6 and Operators now display in Software Catalog.

Screen.Recording.2025-12-03.at.11.36.52.AM.mov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[rhamilto]

/assign @TheRealJon

/cherrypick release-4.20

[coderabbitai]

Walkthrough

Removed dependency on cloudCredentialsLoaded and cloudCredentialsLoadError in useOperatorCatalogItems; cloud credentials are kept in the returned data but are treated as optional and no longer gate the hook's overall loaded/error calculations.

Changes

Cohort / File(s)	Summary
Cloud Credentials Optional State frontend/packages/operator-lifecycle-manager/src/hooks/useOperatorCatalogItems.tsx	Updated hook to only use cloudCredentials (removed cloudCredentialsLoaded and cloudCredentialsLoadError). Adjusted loaded and loadError computations to exclude cloud-credential readiness; preserved cloudCredentials in returned payload and subsequent logic.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

• Localized to a single hook; mostly removal of unused state values.
• Check loaded and loadError correctness after removal.
• Verify callers of the previous hook signature (if any) handle the reduced tuple correctly.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting

📥 Commits

Reviewing files that changed from the base of the PR and between b44bc28 and 4222608.

📒 Files selected for processing (1)

• frontend/packages/operator-lifecycle-manager/src/hooks/useOperatorCatalogItems.tsx (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• frontend/packages/operator-lifecycle-manager/src/hooks/useOperatorCatalogItems.tsx

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-cherrypick-robot]

@rhamilto: once the present PR merges, I will cherry-pick it on top of release-4.20 in a new PR and assign it to you.

Details

In response to this:

/assign @TheRealJon

/cherrypick release-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[rhamilto]

/jira refresh

[openshift-ci-robot]

@rhamilto: This pull request references Jira Issue OCPBUGS-66247, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.21.0) matches configured target version for branch (4.21.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting

📥 Commits

Reviewing files that changed from the base of the PR and between 7d838b5 and b44bc28.

📒 Files selected for processing (1)

• frontend/packages/operator-lifecycle-manager/src/hooks/useOperatorCatalogItems.tsx (1 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

**

⚙️ CodeRabbit configuration file

-Focus on major issues impacting performance, readability, maintainability and security. Avoid nitpicks and avoid verbosity.

Files:

• frontend/packages/operator-lifecycle-manager/src/hooks/useOperatorCatalogItems.tsx

🧬 Code graph analysis (1)

frontend/packages/operator-lifecycle-manager/src/hooks/useOperatorCatalogItems.tsx (1)

frontend/packages/operator-lifecycle-manager/src/hooks/useClusterCloudCredentialConfig.tsx (1)

• useClusterCloudCredentialConfig (9-13)

🔇 Additional comments (2)

frontend/packages/operator-lifecycle-manager/src/hooks/useOperatorCatalogItems.tsx (2)

92-108: LGTM: Correctly implements optional cloudCredentials.

The removal of cloudCredentialsLoaded from the loaded check and cloudCredentialsLoadError from the loadError aggregation correctly implements the PR objective. The operator catalog will now load even when cloudCredentials are unavailable or fail to load, which resolves the issue where operators wouldn't display on clusters without cloudCredentials.

Also applies to: 110-128

---

130-132: Verify that cluster check functions handle undefined cloudCredentials.

Since cloudCredentials can be undefined when not available or failed to load, ensure that isAWSSTSCluster, isAzureWIFCluster, and isGCPWIFCluster handle undefined gracefully without throwing runtime errors. Inspect their implementations in the operator-hub-utils file to confirm they perform null/undefined checks before accessing properties on the cloudCredentials parameter.

[rhamilto]

/retest

[TheRealJon]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhamilto, TheRealJon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• frontend/OWNERS [TheRealJon,rhamilto]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rhamilto]

/label acknowledge-critical-fixes-only

[rhamilto]

/assign @yapei for verification

[openshift-ci]

@rhamilto: GitHub didn't allow me to assign the following users: for, verification.

Note that only openshift members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

Details

In response to this:

/assign @yapei for verification

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci-robot]

/hold

Revision 4222608 was retested 3 times: holding

[rhamilto]

/hold cancel
/test okd-scos-images

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD d00353d and 2 for PR HEAD 4222608 in total

[rhamilto]

/retest

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 9c70ba0 and 1 for PR HEAD 4222608 in total

[rhamilto]

/retest

[jhadvig]

/override ci/prow/okd-scos-images

[openshift-ci]

@jhadvig: Overrode contexts on behalf of jhadvig: ci/prow/okd-scos-images

Details

In response to this:

/override ci/prow/okd-scos-images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 2552602 and 0 for PR HEAD 4222608 in total

[rhamilto]

/retest

[openshift-ci-robot]

/hold

Revision 4222608 was retested 3 times: holding

[rhamilto]

/hold cancel

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 2552602 and 2 for PR HEAD 4222608 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 12dc17b and 1 for PR HEAD 4222608 in total

[rhamilto]

/retest

[rhamilto]

/retest

[jhadvig]

/test backend

[openshift-ci]

@rhamilto: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci-robot]

@rhamilto: Jira Issue Verification Checks: Jira Issue OCPBUGS-66247
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-66247 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

…cloudCredential isn't present on the cluster

Tested against CRC version: 2.57.0+ae41f6 and Operators now display in Software Catalog.

Screen.Recording.2025-12-03.at.11.36.52.AM.mov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-cherrypick-robot]

@rhamilto: new pull request created: #15900

Details

In response to this:

/jira refresh

/cherrypick release-4.21 release-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-cherrypick-robot]

@rhamilto: new pull request created: #15901

Details

In response to this:

/assign @TheRealJon

/cherrypick release-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-merge-robot]

Fix included in accepted release 4.22.0-0.nightly-2026-01-14-031657