Skip to content

Conversation

@sowmya-sl
Copy link
Contributor

@sowmya-sl sowmya-sl commented Jan 16, 2026

OCI-based Helm charts were failing to install because the action configuration lacked a registry client. This change:

  • Add GetDefaultOCIRegistry() to create and attach a registry client to the Helm action configuration
  • Integrate registry client initialization into all Helm handlers: install, upgrade, uninstall, rollback, and chart get operations
  • Add unit tests for the new registry client function
  • Update older tests to use mock registry Client function

Without a registry client, operations on OCI charts (oci://) would fail with errors about missing registry support.

Fixes: HELM-611
Original PR on #15830

OCI-based Helm charts were failing to install because the action
configuration lacked a registry client. This change:

- Add GetDefaultOCIRegistry() to create and attach a registry client
  to the Helm action configuration
- Integrate registry client initialization into all Helm handlers:
  install, upgrade, uninstall, rollback, and chart get operations
- Add unit tests for the new registry client function
- Update older tests to use mock registry Client function

Without a registry client, operations on OCI charts (oci://) would fail
with errors about missing registry support.

Fixes: HELM-611
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 16, 2026

@sowmya-sl: This pull request references HELM-611 which is a valid jira issue.

Details

In response to this:

OCI-based Helm charts were failing to install because the action configuration lacked a registry client. This change:

  • Add GetDefaultOCIRegistry() to create and attach a registry client to the Helm action configuration
  • Integrate registry client initialization into all Helm handlers: install, upgrade, uninstall, rollback, and chart get operations
  • Add unit tests for the new registry client function
  • Update older tests to use mock registry Client function

Without a registry client, operations on OCI charts (oci://) would fail with errors about missing registry support.

Fixes: HELM-611

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 16, 2026
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 16, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 16, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 16, 2026

@sowmya-sl: This pull request references HELM-611 which is a valid jira issue.

Details

In response to this:

OCI-based Helm charts were failing to install because the action configuration lacked a registry client. This change:

  • Add GetDefaultOCIRegistry() to create and attach a registry client to the Helm action configuration
  • Integrate registry client initialization into all Helm handlers: install, upgrade, uninstall, rollback, and chart get operations
  • Add unit tests for the new registry client function
  • Update older tests to use mock registry Client function

Without a registry client, operations on OCI charts (oci://) would fail with errors about missing registry support.

Fixes: HELM-611

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai
Copy link

coderabbitai bot commented Jan 16, 2026

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (1)
  • do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci bot added the component/backend Related to backend label Jan 16, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 16, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sowmya-sl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 16, 2026
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 16, 2026

@sowmya-sl: This pull request references HELM-611 which is a valid jira issue.

Details

In response to this:

OCI-based Helm charts were failing to install because the action configuration lacked a registry client. This change:

  • Add GetDefaultOCIRegistry() to create and attach a registry client to the Helm action configuration
  • Integrate registry client initialization into all Helm handlers: install, upgrade, uninstall, rollback, and chart get operations
  • Add unit tests for the new registry client function
  • Update older tests to use mock registry Client function

Without a registry client, operations on OCI charts (oci://) would fail with errors about missing registry support.

Fixes: HELM-611
Original PR on #15830

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. component/backend Related to backend do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants