OLS-2506: Fix bug where window.close was called after ACM attach

[kyoto]

Normally the browser will deny the window.close call, but it is permitted if the tab was opened with window.open, so in that case the browser tab would close after attaching the ACM cluster details to the prompt.

Also renames other close functions to avoid the risk of accidentally calling window.close again.

[openshift-ci-robot]

@kyoto: This pull request references OLS-2506 which is a valid jira issue.

Details

In response to this:

Normally the browser will deny the window.close call, but it is permitted if the tab was opened with window.open, so in that case the browser tab would close after attaching the ACM cluster details to the prompt.

Also renames other close functions to avoid the risk of accidentally calling window.close again.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@kyoto: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.