OU-1177: DashboardListPage Create Button #734
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@zhuje: This pull request references OU-1177 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zhuje The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
cc: @jgbernalp |
|
|
||
| if (!selectedProject || !dashboardName.trim()) { | ||
| const errors: { [key: string]: string } = {}; | ||
| if (!selectedProject) errors.project = 'Project is required'; |
There was a problem hiding this comment.
all static texts should always have translations
There was a problem hiding this comment.
Adding translations in the latest push.
| value={dashboardName} | ||
| onChange={handleSetDashboardName} | ||
| /> | ||
| {formErrors.dashboardName && ( |
There was a problem hiding this comment.
We should we use the standard Patternfly alerts or guidelines on how to display errors below fields
There was a problem hiding this comment.
Used Patternfly component "TextInput" validation function instead of custom alerts.
| return ( | ||
| <> | ||
| <DocumentTitle>{t('Metrics dashboards')}</DocumentTitle> | ||
| <PageSection |
There was a problem hiding this comment.
it seems we are customizing this PageSection above as well. Do we need this component? what does it bring if we are customizing all the padding.
There was a problem hiding this comment.
Removed "PageSection" and created dashboard-page-padding.tsx.
| > | ||
| <ModalHeader title="Create Dashboard" /> | ||
| <ModalBody> | ||
| {formErrors.general && ( |
There was a problem hiding this comment.
same here, maybe we should use a standard Patterfly component to display errors
There was a problem hiding this comment.
Used Patternfly component "Alert" instead of custom alerts.
…ustom, remove <PageSection /> because we are overriding padding
3 participants
OU-1177 DashboardListPage] Create Button
OU-1173 [DashboardPage / DashboardListPage] Reduce Vertical spacing page title + description
OU-1179 [DashboardListPage] Remove BreadCrumb
Screen.Recording.2026-01-15.at.6.11.50.PM.mov