[OSDOCS#17598]: Added new module for removing device and device classes for 4.21

[bjahagir-OpenShift]

Version(s):
4.21

Issue:
https://issues.redhat.com/browse/OSDOCS-17598
https://issues.redhat.com/browse/OCPSTRAT-1698

Link to docs preview:
https://105230--ocpdocs-pr.netlify.app/openshift-enterprise/latest/storage/persistent_storage_local/persistent-storage-using-lvms.html#about-removing-devices-deviceclasses-from-a-vg_logical-volume-manager-storage

QE review:

• QE has approved this change.

Additional information:

[ocpdocs-previewbot]

🤖 Thu Jan 22 15:39:59 - Prow CI generated the docs preview:

https://105230--ocpdocs-pr.netlify.app/openshift-enterprise/latest/storage/persistent_storage_local/persistent-storage-using-lvms.html

[openshift-ci]

@bjahagir-OpenShift: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[bjahagir-OpenShift]

@qJkee and @mmakwana30 - This is the new PR for addition of new topic Removal of devices and device classes from LVMS. Kindly review.

[stevsmit]

Overall looks pretty good. Some suggestions. I assume that this is one of your first/early PRs so nice job.

Make sure that the WARNINGS need to be warnings and not IMPORTANT; I'm not sure how this CR works really. Here's the link to the differences:

https://redhat-documentation.github.io/supplementary-style-guide/#admonitions

You could also do something like make "Removing the device paths in the deviceSelector.paths field" a level 2 subheading under "About removing devices and device classes from a volume group". For example:

= About removing devices and device classes from a volume group

== Removing the device paths in the deviceSelector.paths field

== Removing the deviceClass from the LVMCluster

in the same module. It's kind of up to you. Just an idea.

This will need QE ack before I can merge.

[stevsmit]

This is a sentence fragment. These types of fragments are OK for prerequisite sections or even as bullet points, but in this WARNING admonition it's a little off. I suggest rewording it slightly and adding bullet points:

Suggested change

	There is at least one more device specified in the `deviceSelector.paths` field.
	[WARNING]
	====
	Ensure that the following criteria are met before removing device paths:
	* The device that you want to remove is empty. You can use the `pvdisplay` command to view attributes of physical volumes (PVs) used in LVM.
	* At least one additional device is specified in the `deviceSelector.paths` field.
	====

Note the period at the end of the first sentence, which is missing on line 17.

[stevsmit]

Backspace this line up so that it sits on line 10. I'm not 100% sure how the tagging will work in DITA but just to be safe...

Suggested change

	The `deviceSelector` field in the `LVMCluster` CR contains the configuration to specify the paths to the devices that you can remove from the Logical Volume Manager (LVM) volume group.
	[role="_abstract"]
	The `deviceSelector` field in the `LVMCluster` CR contains the configuration to specify the paths to the devices that you can remove from the Logical Volume Manager (LVM) volume group.

[stevsmit]

We generally follow items that are in backticks with nouns. For example:

Suggested change

	You can also remove the deviceClass from the `LVMCluster`. For device class deletion, there is no need to delete `deviceSelector.paths`.
	You can also remove the `deviceClass` object from the `LVMCluster` resource. For device class deletion, there is no need to delete `deviceSelector.paths` object.

[stevsmit]

Same suggestion as above:

Suggested change

	Ensure that the `deviceClasses.default` is set to `false`.
	[WARNING]
	====
	Ensure that the following criteria are met before removing a device class:
	* The `deviceClasses.default` field is set to `false`.
	* The disks specified in the `deviceSelector.paths` field are empty.
	* At least one additional device class is specified in the `storage` field.
	====