-
Notifications
You must be signed in to change notification settings - Fork 135
OCPBUGS-72591: Lower verbosity for parseIPList empty list logging #709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
OCPBUGS-72591: Lower verbosity for parseIPList empty list logging #709
Conversation
Since it's impossible to distinguish between an unset value and a value set as empty, we prefer to lower the verbosity from V(0) to V(7) to reduce unnecessary logging.
|
@alebedev87: This pull request references Jira Issue OCPBUGS-72591, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@alebedev87: This pull request references Jira Issue OCPBUGS-72591, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@alebedev87: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/assign |
|
/approve Do we document the various log levels anywhere? It would be useful to have some guidance for both developers and end users, to help everyone understand in general terms what gets logged (or should be logged) at a given log level. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Miciah The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Since it's impossible to distinguish between an unset value and a value set as empty, we prefer to lower the verbosity from V(0) to V(7) to reduce unnecessary logging.