Skip to content

Conversation

@rebtoor
Copy link
Contributor

@rebtoor rebtoor commented Jan 20, 2026

Check both 'is defined' and 'length > 0' for deployment_version so empty strings correctly fall through to approve any unapproved manual InstallPlan instead of filtering for 'openstack-operator.' (no version).

…is empty

Check both 'is defined' and 'length > 0' for deployment_version so
empty strings correctly fall through to approve any unapproved manual
InstallPlan instead of filtering for 'openstack-operator.' (no version).

Signed-off-by: Roberto Alfieri <ralfieri@redhat.com>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 20, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign amartyasinha for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/b1430f60de5f4b2c9a5f19ab9df4e054

openstack-k8s-operators-content-provider FAILURE in 4m 42s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal-minor-update SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
✔️ cifmw-pod-zuul-files SUCCESS in 4m 57s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 9m 32s
cifmw-pod-pre-commit TIMED_OUT in 31m 07s
✔️ cifmw-architecture-validate-hci SUCCESS in 3m 47s
✔️ cifmw-molecule-kustomize_deploy SUCCESS in 4m 02s

@rebtoor
Copy link
Contributor Author

rebtoor commented Jan 20, 2026

recheck

@amartyasinha amartyasinha merged commit daa7918 into openstack-k8s-operators:main Jan 21, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants