WIP: Trigger nodeSet reconciler with ansibleVarsFrom changes #1766
Conversation
The NodeSet reconciler would not triggered on changes to ConfigMaps and Secrets from ansibleVarsFrom as we never check than and it won't update the nodeset status and message to mark it ready to changes Jira: OSPRH-17961
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: oliashish The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
oliashish
force-pushed
the
fix/nodeset-reconcile-with-secret-change
branch
from
363aa04 to
041c79f
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/2f91f3518f594651aa31a353d4524c5a ❌ openstack-k8s-operators-content-provider FAILURE in 5m 19s |
internal/dataplane/hashes.go
Outdated
| } | ||
|
|
||
| // GetNodeSetAnsibleVarsFromHashes computes hashes for ConfigMaps and Secrets | ||
| // referenced in the NModeSet's AnsibleVarsFrom field (both NodeTemplate and |
|
@oliashish: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
slagle
left a comment
slagle
left a comment
There was a problem hiding this comment.
this looks good. I can test it in my environment as well.
| // ProcessAnsibleVarsFrom computes hashes for ConfigMaps and Secrets | ||
| // referenced in the NodeSet's AnsibleVarsFrom field (both NodeTemplate and | ||
| // individual Nodes) | ||
|
|
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/50b1d132f5ab43838db660d50fa0e335 ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 56m 28s |
The NodeSet reconciler would not triggered on changes to ConfigMaps and Secrets from ansibleVarsFrom as we never check than and it won't update the nodeset status and message to mark it ready to changes
Jira: OSPRH-17961