Add base envTests to test-operator #388
Conversation
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kstrenkova The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Unable to freeze job graph: Job podified-multinode-edpm-deployment-crc-test-operator depends on openstack-k8s-operators-content-provider which was not run. |
kstrenkova
force-pushed
the
add-basic-env-tests
branch
from
af2d5df to
c7713f9
Compare
|
Unable to freeze job graph: Job podified-multinode-edpm-deployment-crc-test-operator depends on openstack-k8s-operators-content-provider which was not run. |
kstrenkova
force-pushed
the
add-basic-env-tests
branch
from
c7713f9 to
4a7caba
Compare
|
Unable to freeze job graph: Job podified-multinode-edpm-deployment-crc-test-operator depends on openstack-k8s-operators-content-provider which was not run. |
kstrenkova
force-pushed
the
add-basic-env-tests
branch
from
4a7caba to
47e887e
Compare
|
Unable to freeze job graph: Job podified-multinode-edpm-deployment-crc-test-operator depends on openstack-k8s-operators-content-provider which was not run. |
kstrenkova
force-pushed
the
add-basic-env-tests
branch
from
47e887e to
0fb11ba
Compare
|
Unable to freeze job graph: Job podified-multinode-edpm-deployment-crc-test-operator depends on openstack-k8s-operators-content-provider which was not run. |
kstrenkova
force-pushed
the
add-basic-env-tests
branch
from
0fb11ba to
d13a5aa
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/ae207385ad904209a959b109e0ea58ab ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 35m 36s |
|
recheck |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/251eb2c884a94d11b5376908cfb40464 ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 05m 23s |
kstrenkova
force-pushed
the
add-basic-env-tests
branch
from
d13a5aa to
e428634
Compare
Currently, test-operator only has one suite envTest. To keep best practices we shold add more tests for test-operator functionality to prevent regression. This PR starts by adding base envTests that can be improved in the future.
This change enables meta-operator build and removes custom bundle overrides to make it more similar to other operators and to fix errors when adding only envTests (job wouldn't run). Now the PR changes will be tested via the standard openstack-operator build instead of CSV patching.
kstrenkova
force-pushed
the
add-basic-env-tests
branch
from
e428634 to
45f899d
Compare
There was a problem hiding this comment.
Hi @stuggi 👋 Could I ask you to check this change?
As you can see on the PR, I encountered some errors when adding only envTests and then arrived to the conclusion that maybe these variables were not needed - it passes now plus it will be similar to other operators under openstack-operator. So I wanted to double-check if this wouldn't be a breaking change.
1 participant
Currently, test-operator only has one suite envTest. To keep best practices we shold add more tests for test-operator functionality to prevent regression. This PR starts by adding base envTests that can be improved in the future.