Changing --enable_prefix_caching param to be consistant with ovms cli api #3936
+17
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the --enable_prefix_caching parameter to align with OVMS CLI API conventions by changing it from an action flag to a boolean type with a default value of True. Since prefix caching is now enabled by default, all explicit usages of this parameter have been removed from documentation examples. Additionally, the "devstral" option has been added to the tool_parser choices.
Changes:
- Modified
--enable_prefix_cachingargument fromaction='store_true'totype=boolwithdefault=True - Removed
--enable_prefix_cachingflags from all command examples across documentation - Added "devstral" as a new tool_parser option
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| demos/continuous_batching/accuracy/README.md | Removed --enable_prefix_caching flag from export_model command example |
| demos/common/export_models/export_model.py | Changed enable_prefix_caching to boolean type with True default; added devstral to tool_parser choices |
| demos/common/export_models/README.md | Updated help text to reflect new boolean parameter type and added devstral to tool_parser options |
| demos/code_local_assistant/README.md | Removed --enable_prefix_caching flags from multiple export_model and ovms command examples |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
przepeck
commented
Jan 30, 2026
| @@ -21,7 +21,7 @@ mkdir models | |||
| python demos/common/export_models/export_model.py text_generation --source_model meta-llama/Meta-Llama-3-8B-Instruct --weight-format fp16 --kv_cache_precision u8 --config_file_path models/config.json --model_repository_path models | |||
| python demos/common/export_models/export_model.py text_generation --source_model meta-llama/Meta-Llama-3-8B --weight-format fp16 --kv_cache_precision u8 --config_file_path models/config.json --model_repository_path models | |||
| python demos/common/export_models/export_model.py text_generation --source_model OpenGVLab/InternVL2_5-8B --weight-format fp16 --config_file_path models/config.json --model_repository_path models | |||
Collaborator
Author
There was a problem hiding this comment.
should I add --enable_prefix_caching false to these commands?
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠 Summary
CVS-179961
Changing --enable_prefix_caching param to be consistent with ovms cli api, dropping this param since its true by default now,
Adding devstral tool_parser option to export_model
🧪 Checklist
``