Skip to content

Conversation

@dtrawins
Copy link
Collaborator

🛠 Summary

JIRA/Issue if applicable.
Describe the changes.

🧪 Checklist

  • Unit tests added.
  • The documentation updated.
  • Change follows security best practices.
    ``

Copilot AI review requested due to automatic review settings January 30, 2026 11:57
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Red Hat Universal Base Image (UBI) version from 9.6 to 9.7 across the codebase and adds a directory copy operation in the Ubuntu Dockerfile.

Changes:

  • Updated UBI base image references from version 9.6 to 9.7
  • Added Intel directory copy operation to root in Ubuntu Dockerfile
  • Updated version references in Makefiles and Dockerfiles

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
demos/python_demos/Dockerfile.ubuntu Added command to copy Intel directory to root filesystem
demos/c_api_minimal_app/capi_files/Dockerfile.redhat Updated UBI base and minimal images to version 9.7
Makefile Updated RedHat base OS tag and docker run image reference to version 9.7
Dockerfile.redhat Updated UBI base, release base, and build base images to version 9.7

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@@ -22,7 +22,7 @@ RUN apt update && apt install -y python3-pip git
COPY requirements.txt .
ENV PIP_BREAK_SYSTEM_PACKAGES=1
RUN BUILD_CUDA_EXT=0 pip3 install -r requirements.txt --no-cache-dir
Copy link

Copilot AI Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The addition of && cp -R /root/intel / lacks explanation. This command copies the Intel directory to the root filesystem, but there's no comment explaining why this is necessary or what this directory contains. Consider adding a comment to explain the purpose of this operation.

Suggested change
RUN BUILD_CUDA_EXT=0 pip3 install -r requirements.txt --no-cache-dir
RUN BUILD_CUDA_EXT=0 pip3 install -r requirements.txt --no-cache-dir
# Configure Intel telemetry/usage collection to opt-out for all users;
# `opt_in_out` writes settings under /root/intel, which we copy to / so they
# are available system-wide (including for the non-root ovms user).

Copilot uses AI. Check for mistakes.
ifeq ($(BASE_OS),redhat)
touch base_packages.txt
docker run registry.access.redhat.com/ubi9-minimal:9.6 rpm -qa --qf "%{NAME}\n" | sort > base_packages.txt
docker run registry.access.redhat.com/ubi9-minimal:9.7 rpm -qa --qf "%{NAME}\n" | sort > base_packages.txt
Copy link

Copilot AI Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image name inconsistency: this line uses 'ubi9-minimal' while other files use 'ubi9/ubi-minimal'. Verify this is the correct image reference format for Red Hat's registry.

Suggested change
docker run registry.access.redhat.com/ubi9-minimal:9.7 rpm -qa --qf "%{NAME}\n" | sort > base_packages.txt
docker run registry.access.redhat.com/ubi9/ubi-minimal:9.7 rpm -qa --qf "%{NAME}\n" | sort > base_packages.txt

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants