-
Notifications
You must be signed in to change notification settings - Fork 238
update ubi base image #3938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
update ubi base image #3938
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the Red Hat Universal Base Image (UBI) version from 9.6 to 9.7 across the codebase and adds a directory copy operation in the Ubuntu Dockerfile.
Changes:
- Updated UBI base image references from version 9.6 to 9.7
- Added Intel directory copy operation to root in Ubuntu Dockerfile
- Updated version references in Makefiles and Dockerfiles
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| demos/python_demos/Dockerfile.ubuntu | Added command to copy Intel directory to root filesystem |
| demos/c_api_minimal_app/capi_files/Dockerfile.redhat | Updated UBI base and minimal images to version 9.7 |
| Makefile | Updated RedHat base OS tag and docker run image reference to version 9.7 |
| Dockerfile.redhat | Updated UBI base, release base, and build base images to version 9.7 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -22,7 +22,7 @@ RUN apt update && apt install -y python3-pip git | |||
| COPY requirements.txt . | |||
| ENV PIP_BREAK_SYSTEM_PACKAGES=1 | |||
| RUN BUILD_CUDA_EXT=0 pip3 install -r requirements.txt --no-cache-dir | |||
Copilot
AI
Jan 30, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The addition of && cp -R /root/intel / lacks explanation. This command copies the Intel directory to the root filesystem, but there's no comment explaining why this is necessary or what this directory contains. Consider adding a comment to explain the purpose of this operation.
| RUN BUILD_CUDA_EXT=0 pip3 install -r requirements.txt --no-cache-dir | |
| RUN BUILD_CUDA_EXT=0 pip3 install -r requirements.txt --no-cache-dir | |
| # Configure Intel telemetry/usage collection to opt-out for all users; | |
| # `opt_in_out` writes settings under /root/intel, which we copy to / so they | |
| # are available system-wide (including for the non-root ovms user). |
| ifeq ($(BASE_OS),redhat) | ||
| touch base_packages.txt | ||
| docker run registry.access.redhat.com/ubi9-minimal:9.6 rpm -qa --qf "%{NAME}\n" | sort > base_packages.txt | ||
| docker run registry.access.redhat.com/ubi9-minimal:9.7 rpm -qa --qf "%{NAME}\n" | sort > base_packages.txt |
Copilot
AI
Jan 30, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Image name inconsistency: this line uses 'ubi9-minimal' while other files use 'ubi9/ubi-minimal'. Verify this is the correct image reference format for Red Hat's registry.
| docker run registry.access.redhat.com/ubi9-minimal:9.7 rpm -qa --qf "%{NAME}\n" | sort > base_packages.txt | |
| docker run registry.access.redhat.com/ubi9/ubi-minimal:9.7 rpm -qa --qf "%{NAME}\n" | sort > base_packages.txt |
🛠 Summary
JIRA/Issue if applicable.
Describe the changes.
🧪 Checklist
``