You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Do you want to try and also create a test page that uses setTimeout and assert that we now capture the full callstack as was asked in the last line of the original issue?
Do you want to try and also create a test page that uses setTimeout and assert that we now capture the full callstack as was asked in the last line of the original issue?
Hello @vringar I know lil bit about setTimeout function but I have no idea how we are gonna implement here.
can you help me with that sir?
Hey,
please create a HTML page under test/test_pages and create an inline script that uses set timeout before printing to console.
I'll explain further once this is done.
Hey,
please create a HTML page under test/test_pages and create an inline script that uses set timeout before printing to console.
I'll explain further once this is done.
Hey,
I have underestimated the complexity of writing a test for this pref and don't have the time to mentor you on this any further.
I'm sorry about that!
Would it be okay for you to switch to something like #915 or #916 and leave this PR open for a while?
Hey,
I have underestimated the complexity of writing a test for this pref and don't have the time to mentor you on this any further.
I'm sorry about that!
Would it be okay for you to switch to something like #915 or #916 and leave this PR open for a while?
Okay Sir, Sure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added Set
javascript.options.asyncstack to truein the functiondef optimize_prefs(prefs: Dict[str, Any]) -> None:Closes #678