Fix reference resolution for YAML and JSON strings#54
Merged
Conversation
fbed33f to
628def7
Compare
osteel
commented
Nov 27, 2025
Comment on lines
+21
to
+22
| with: | ||
| php-version: "8.0" |
Owner
Author
There was a problem hiding this comment.
ℹ️ Run these checks with the minimum supported PHP version
Owner
Author
|
Hey @dafeder, as a sanity check before I merge this, would you mind loading this branch in your app and make sure that it fixes your use case please? |
628def7 to
4bd3bc1
Compare
Owner
Author
|
@dafeder excellent! Thanks for checking. Will merge and release shortly |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue introduced with #52 where references in OpenAPI definitions as JSON or YAML strings weren't resolved properly anymore.
Explanation
Fixes #53.
This package previously used OpenAPI PSR-7 Message Validator's factories to create
OpenApispec objects, which also resolved references in case of definition passed as a string (seeJsonFactoryfor instance).When moving away from these factories to introduce support for URLs, manual reference resolution wasn't ported over.
Checklist