A couple little ereport refactors #2359
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hawkw
force-pushed
the
eliza/erefactor
branch
from
f9f4a9d to
108e2e8
Compare
Presently, the `cosmo_seq::vcore` module still uses `serde` to encode ereports rather than using `microcbor`. This is due to some kind of oversight on my part. It's sad for it to do that because the new `microcbor` crate lets us have a statically calculated buffer length for the ereport. This commit changes it to use the new and proper ereport serialization API instead of the old and unpreferred one.
@cbiffle noted (quite rightly!) yesterday that the name of `Packrat::encode_ereport` was somewhat unclear, as it both encodes the ereport *and* delivers it to Packrat. This commit renames the method and adds some slightly nicer documentation to it.
hawkw
force-pushed
the
eliza/erefactor
branch
from
108e2e8 to
b142c9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch makes a couple very small refactors to ereport reporting (which I intend to merge as independent commits and are best reviewed as such). In particular:
cosmo-seq: use
microcborfor Vcore ereports (cf2e23b)Presently, the
cosmo_seq::vcoremodule still usesserdeto encodeereports rather than using
microcbor. This is due to some kind ofoversight on my part. It's sad for it to do that because the new
microcborcrate lets us have a statically calculated buffer length forthe ereport. This commit changes it to use the new and proper ereport
serialization API instead of the old and unpreferred one.
packrat-api: Rename and document ereport delivery methods (f9f4a9d)
@cbiffle noted (quite rightly!) yesterday that the name of
Packrat::encode_ereportwas somewhat unclear, as it both encodes theereport and delivers it to Packrat. This commit renames the method and
adds some slightly nicer documentation to it.