bug fix where param_to_type_map was never populated causing type to b…#6
Open
olaghattas wants to merge 1 commit intopac48:mainfrom
Open
bug fix where param_to_type_map was never populated causing type to b…#6olaghattas wants to merge 1 commit intopac48:mainfrom
olaghattas wants to merge 1 commit intopac48:mainfrom
Conversation
…e an empty string and init of the problem doesnt get populated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When objects in the PDDL have types and load_kb is used, getPlan fails to generate any plan because the init function is not populated correctly due to a type mismatch in the parse_predicate function.
Specifically, the following code:
relies on param_to_type_map being populated, but in the original implementation this map was only initialized and never filled with values, causing the type information to be missing.