-
Notifications
You must be signed in to change notification settings - Fork 114
chore(IT-Wallet): [SIW-3468] Add origin to serialize failure reason to enhance mixpanel tracking on unexpected failures #7684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
PR Title Validation for conventional commit type✅ All good! PR title follows the conventional commit type. |
Jira Pull Request LinkThis Pull Request refers to Jira issues: |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #7684 +/- ##
=======================================
Coverage 59.97% 59.98%
=======================================
Files 1898 1898
Lines 41445 41450 +5
Branches 9535 9616 +81
=======================================
+ Hits 24858 24865 +7
+ Misses 16510 16497 -13
- Partials 77 88 +11
... and 12 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
I am not totally convinced of this new Was it asked explicitly by the analytics team? |
|
@gispada |
Short description
Add origin context to all “unexpected” IT Wallet analytics events so Mixpanel receives more actionable reasons instead of generic
UNEXPECTEDvalues.List of changes proposed in this pull request
How to test
Unexpected test cases are unpredictable; in the current state, I couldn't cover the tests for this scenario.