feat(IT-Wallet): [SIW-3306] Add engagement banners to wallet home screen #7708
+2,583
−2,196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
PR Title Validation for conventional commit type✅ All good! PR title follows the conventional commit type. |
Contributor
Jira Pull Request LinkThis Pull Request refers to Jira issues: |
mastro993
changed the title
mastro993
changed the title
Comment on lines
-54
to
+56
| } else if ( | ||
| !isWalletValid || | ||
| (!isITWalletValid && isNewCredential(type)) | ||
| ) { | ||
| } else if (isL3Enabled && !isItWalletValid) { |
Collaborator
There was a problem hiding this comment.
With Documenti su IO enabled and the user clicks on a non-new credential, the PID issuance flow is started. Instead, the issuance flow of the selected credential should be triggered.
Contributor
Author
There was a problem hiding this comment.
When Documenti su IO is enabled, tapping on a credential starts the credential issuing correctly.
When Documenti su IO is not enabled, credentials are not visibile in the list.
Can you attach a video of the issue? Just to ensure I understand correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning
Depends on #7735
Short description
This PR introduces the new IT-Wallet engagement banner with the new brand identity, replacing the legacy highlight banner.
List of changes proposed in this pull request
New IT-Wallet Activation/Engagement Banner:
ItwActivationBannercomponent that displays an activation prompt for eligible users and navigates them to the onboarding flow. The banner uses the newItwEngagementBannerfor consistent design and accessibility. [1] [2]index.json) with new and revised strings for the IT-Wallet engagement and upgrade banners, including activation, upgrade, expiring, and dismiss alert texts.Component and UI Refactors:
ItwEngagementBanner, a reusable, accessible banner component with markdown support, custom close/dismiss logic, and a branded design.ItwBrandedBoxandItwBrandedSkiaBordercomponents to use a consistentborderRadiusprop (renamed fromcornerRadius), improving customization and code clarity. Updated all usages accordingly. [1] [2] [3] [4] [5] [6] [7] [8] [9]Cleanup and Minor Improvements:
ItwHighlightBannercomponent and all related code, as it has been replaced by the new engagement banner.ItwEnvironmentAlertcomponent by wrapping it in a view with vertical margin. [1] [2] [3]How to test
Note
This PR does not include the banners dismissal logic. It will be implemented in a different PR.
With the L3 whitelist flag enabled, verify that the engagement banners are rendered correctly in the wallet's home screen as shown in the Figma design.
Banners should have different copy based on the wallet status (empty, with credentials or with expiring credentials).
Preview