Make DefaultCas public to allow building custom truststores#3312
Open
Eric-Alvarez wants to merge 1 commit intodevelopfrom
Open
Make DefaultCas public to allow building custom truststores#3312Eric-Alvarez wants to merge 1 commit intodevelopfrom
Eric-Alvarez wants to merge 1 commit intodevelopfrom
Conversation
Generate changelog in
|
✅ Successfully generated changelog entry!Need to regenerate?Simply interact with the changelog bot comment again to regenerate these entries. 📋Changelog Preview💡 Improvements
|
Member
|
I don't think it should be this libraries responsibility to provide this utility for arbitrary clients. Different clients may have very different expectations or requirements for what is included here. Exposing this API greatly increases the responsibility shouldered by this library for things that are mostly not it's concern. If we wanted to expose a library for this, it should be pulled out to a dedicated library where that is expressly it's goal. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this PR
DefaultCas is package-private which does not allow building custom truststores that trust default cas
After this PR
==COMMIT_MSG==
==COMMIT_MSG==
DefaultCas class is public to allow clients to build custom truststores
Possible downsides?