Support Ruby 3.4, update datadog dependency, bump version#14
Open
sagarjunnarkar wants to merge 2 commits intomainfrom
Open
Support Ruby 3.4, update datadog dependency, bump version#14sagarjunnarkar wants to merge 2 commits intomainfrom
sagarjunnarkar wants to merge 2 commits intomainfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the gem to support Ruby 3.4 by upgrading the Datadog dependency from ddtrace to datadog v2.0 and setting an upper Ruby version constraint. The version is bumped from 1.0.4 to 1.0.5.
- Updated Datadog dependency from
ddtrace(>= 1.13.0) todatadog(~> 2.0) - Added upper Ruby version constraint (< 4.0) while maintaining lower bound of >= 2.7.0
- Bumped gem version from 1.0.4 to 1.0.5
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| lib/datadog_notifier/version.rb | Incremented VERSION constant from '1.0.4' to '1.0.5' |
| datadog_notifier.gemspec | Updated datadog dependency and added Ruby version upper bound |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Collaborator
Author
amoludage
approved these changes
Nov 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Details
Clickup Link -
Description
Types of changes
Checklist